content/browser/renderer_host/render_widget_host_view_mac.mm - Issue 2163953002: rebaseline huge-image-viewport-scale.html

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_widget_host_view_mac.mm

Issue 2163953002: rebaseline huge-image-viewport-scale.html (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: mac doesn't use aura, needs an equivalent change Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/renderer_host/render_widget_host_view_mac.mm

diff --git a/content/browser/renderer_host/render_widget_host_view_mac.mm b/content/browser/renderer_host/render_widget_host_view_mac.mm

index 0dc3ef091766a161c2af2c3a9f3e4e66f8a37342..c034ef964ae70ae59e0fc96efd666a775deaa46d 100644

--- a/content/browser/renderer_host/render_widget_host_view_mac.mm

+++ b/content/browser/renderer_host/render_widget_host_view_mac.mm

@@ -521,6 +521,14 @@ RenderWidgetHostViewMac::RenderWidgetHostViewMac(RenderWidgetHost* widget,

->GetInputEventRouter()

->AddSurfaceClientIdOwner(GetSurfaceClientId(), this);

}

+ RenderViewHost* rvh = RenderViewHost::From(render_widget_host_);

+ if (rvh) {

+ WebPreferences prefs = rvh->GetWebkitPreferences();

+ // TODO(mostynb): actually use prefs. Landing this as a separate CL

+ // first to rebaseline some unreliable layout tests.

+ (void)prefs;

Avi (use Gerrit) 2016/07/20 18:25:36 ignore_result() from base/macros.h?

Mostyn Bramley-Moore 2016/07/20 18:48:38 Done.

+ }

}

RenderWidgetHostViewMac::~RenderWidgetHostViewMac() {