Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 2163943002: Clean up Valgrind gtest filters for remoting_unittests and unit_tests (Closed)

Created:
4 years, 5 months ago by Alexander Potapenko
Modified:
4 years, 5 months ago
Reviewers:
Lei Zhang, benwells
CC:
chromium-reviews, glider+watch_chromium.org, bruening+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clean up Valgrind gtest filters for remoting_unittests and unit_tests The bots have been retired, there's little point in keeping the filters for bugs that have been WontFixed. BUG=496910, 241856, 44552, 139652, 179427, 180335, 238964, 483642 TBR=benwells@chromium.org NOTRY=true Committed: https://crrev.com/3c4b53938cde1faa4d609ad34646ed859f33a524 Cr-Commit-Position: refs/heads/master@{#406533}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -24 lines) Patch
D tools/valgrind/gtest_exclude/remoting_unittests.gtest.txt View 1 chunk +0 lines, -5 lines 0 comments Download
M tools/valgrind/gtest_exclude/unit_tests.gtest_linux.txt View 1 chunk +0 lines, -19 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Alexander Potapenko
On 2016/07/20 11:30:18, Alexander Potapenko wrote: > Description was changed from > > ========== > ...
4 years, 5 months ago (2016-07-20 11:30:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2163943002/1
4 years, 5 months ago (2016-07-20 11:30:48 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-20 12:58:42 UTC) #6
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-20 12:58:50 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/3c4b53938cde1faa4d609ad34646ed859f33a524 Cr-Commit-Position: refs/heads/master@{#406533}
4 years, 5 months ago (2016-07-20 13:01:29 UTC) #9
Lei Zhang
4 years, 5 months ago (2016-07-20 18:39:41 UTC) #11
Message was sent while issue was closed.
lgtm, but we may just delete all the Valgrind bits once we finish closing out
all the Valgrind-only bugs.

Powered by Google App Engine
This is Rietveld 408576698