src/builtins/builtins-function.cc - Issue 2163933002: Move CompileString to Compiler

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/builtins/builtins-function.cc

Issue 2163933002: Move CompileString to Compiler (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/builtins/builtins-function.cc

diff --git a/src/builtins/builtins-function.cc b/src/builtins/builtins-function.cc

index 12a94a63eb67258675c04cbe1d017764a9b674ba..0ab52f1fe5800283ea8a77fe54f93b46297d7eba 100644

--- a/src/builtins/builtins-function.cc

+++ b/src/builtins/builtins-function.cc

@@ -5,6 +5,7 @@

#include "src/builtins/builtins.h"

#include "src/builtins/builtins-utils.h"

+#include "src/compiler.h"

#include "src/string-builder.h"

namespace v8 {

@@ -104,7 +105,7 @@ MaybeHandle<Object> CreateDynamicFunction(Isolate* isolate,

{

ASSIGN_RETURN_ON_EXCEPTION(

isolate, function,

- Builtins::CompileString(handle(target->native_context(), isolate),

+ Compiler::CompileString(handle(target->native_context(), isolate),

source, ONLY_SINGLE_FUNCTION_LITERAL),

Object);

Handle<Object> result;