Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 2163903002: Report detailed batch upload error by UMA. (Closed)

Created:
4 years, 5 months ago by hirono
Modified:
4 years, 4 months ago
Reviewers:
kinaba
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Report detailed batch upload error by UMA. Currently chrome reports HTTP response code to UMA and it always -1 when the HTTP connection is failed. The CL let chrome report net status error instead if the response code is -1. BUG=539608 TEST=Sync multiple files in Files.app. Committed: https://crrev.com/fb6bf444b264e85dd51019a59b7e26883f98b934 Cr-Commit-Position: refs/heads/master@{#408926}

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -5 lines) Patch
M google_apis/drive/drive_api_requests.cc View 1 1 chunk +12 lines, -5 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
hirono
PTAL, thank you!
4 years, 5 months ago (2016-07-20 09:42:51 UTC) #3
kinaba
lgtm
4 years, 5 months ago (2016-07-21 00:44:05 UTC) #4
hirono
Thank you!
4 years, 5 months ago (2016-07-21 00:54:23 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2163903002/20001
4 years, 5 months ago (2016-07-21 00:54:40 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/194166)
4 years, 5 months ago (2016-07-21 01:17:30 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2163903002/20001
4 years, 4 months ago (2016-08-01 06:52:58 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-01 07:47:20 UTC) #13
commit-bot: I haz the power
4 years, 4 months ago (2016-08-01 07:49:19 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/fb6bf444b264e85dd51019a59b7e26883f98b934
Cr-Commit-Position: refs/heads/master@{#408926}

Powered by Google App Engine
This is Rietveld 408576698