Issue 21639004: Use first hit when dumping heap constants.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 21639004: Use first hit when dumping heap constants. (Closed)

Created:
7 years, 4 months ago by Michael Starzinger

Modified:
7 years, 4 months ago

Reviewers:
Toon Verwaest

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Use first hit when dumping heap constants. This makes sure that the first hit is used when dumping heap constants and hence "TheHoleValue" is not overwritten with other roots that are initialized to the hole as well. R=verwaest@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=16058

Patch Set 1 #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -7 lines)			Patch
	M	src/d8.cc	View		2 chunks	+3 lines, -3 lines	0 comments	Download
	M	tools/v8heapconst.py	View		3 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

7 years, 4 months ago (2013-08-05 16:47:54 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r16058 (presubmit successful).

Expand Messages | Collapse Messages