Start sending auxclick instead of click for non-primary buttons

third_party/WebKit/Source/devtools/front_end/ui/treeoutline.js

Index: third_party/WebKit/Source/devtools/front_end/ui/treeoutline.js
diff --git a/third_party/WebKit/Source/devtools/front_end/ui/treeoutline.js b/third_party/WebKit/Source/devtools/front_end/ui/treeoutline.js
index 007e68e654979e77f00907ef094dffaeb84aa7a1..eeece70f3a4c115f0b86247139c0d03abfff1053 100644
--- a/third_party/WebKit/Source/devtools/front_end/ui/treeoutline.js
+++ b/third_party/WebKit/Source/devtools/front_end/ui/treeoutline.js
@@ -364,7 +364,7 @@ function TreeElement(title, expandable)
     this._listItemNode.addEventListener("mousedown", this._handleMouseDown.bind(this), false);
     this._listItemNode.addEventListener("selectstart", this._treeElementSelectStart.bind(this), false);
     this._listItemNode.addEventListener("click", this._treeElementToggled.bind(this), false);
-    this._listItemNode.addEventListener("dblclick", this._handleDoubleClick.bind(this), false);
+    this._listItemNode.addEventListener("auxclick", this._treeElementToggled.bind(this), false);

[dgozman, 2016/08/03 20:54:28]

Why change this? Are you going to stop sending dblclick events for main button
as well?

[Navid Zolghadr, 2016/08/03 21:35:20]

We stopped sending dblclick for middle button but not for primary (left) button.
There is this behavior for middle double click in devtools when you double
middle click an html attribute it selects the attribute name and the value
together as oppose to double clicking with left button which only selects the
value. Anyhow this way of handling dblclick would handle them both in one shot
and I thought it is cleaner to handle them both with the detail check. Is that
okay?

[dgozman, 2016/08/03 22:31:49]

I cannot repro the behavior you mention on linux. Perhaps, that's the default
"select on double click" behavior which differs between OSes? Judging by this
code, we have no special handling. I'd prefer to continue using dblclick, so
that double middle click doesn't do this.

[Navid Zolghadr, 2016/08/04 14:42:05]

Sure. done.

 
     this._childrenListNode = createElement("ol");
     this._childrenListNode.parentTreeElement = this;
@@ -784,6 +784,20 @@ TreeElement.prototype = {
     _treeElementToggled: function(event)
     {
         var element = event.currentTarget;
+
+        // Handling dblclick
+        if (event.detail === 2) {
+            if (!element || element.treeElement !== this)
+                return;
+
+            var handled = this.ondblclick(event);
+            if (handled)
+                return;
+            if (this._expandable && !this.expanded)
+                this.expand();
+            return;
+        }
+
         if (element._selectionStarted) {
             delete element._selectionStarted;
             var selection = element.getComponentSelection();
@@ -837,22 +851,6 @@ TreeElement.prototype = {
         this.selectOnMouseDown(event);
     },
 
-    /**
-     * @param {!Event} event
-     */
-    _handleDoubleClick: function(event)
-    {
-        var element = event.currentTarget;
-        if (!element || element.treeElement !== this)
-            return;
-
-        var handled = this.ondblclick(event);
-        if (handled)
-            return;
-        if (this._expandable && !this.expanded)
-            this.expand();
-    },
-
     _detach: function()
     {
         this._listItemNode.remove();