third_party/WebKit/Source/core/html/HTMLAnchorElement.cpp - Issue 2163893003: Start sending auxclick instead of click for non-primary buttons

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLAnchorElement.cpp

Issue 2163893003: Start sending auxclick instead of click for non-primary buttons (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Start sending auxclick instead of click for non-primary buttons Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/frame/UseCounter.h ('k') | third_party/WebKit/Source/core/input/EventHandler.cpp » ('j') | third_party/WebKit/Source/devtools/front_end/ui/TabbedPane.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/HTMLAnchorElement.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLAnchorElement.cpp b/third_party/WebKit/Source/core/html/HTMLAnchorElement.cpp

index f3d3de831bf09579062473a811d0312d14b9be1e..2375afbf91e882bb615232eb97853b8c18bc4918 100644

--- a/third_party/WebKit/Source/core/html/HTMLAnchorElement.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLAnchorElement.cpp

@@ -456,7 +456,7 @@ bool isEnterKeyKeydownEvent(Event* event)

bool isLinkClick(Event* event)

{

// Allow detail <= 1 so that synthetic clicks work. They may have detail == 0.

- return event->type() == EventTypeNames::click && (!event->isMouseEvent() || (toMouseEvent(event)->button() != RightButton && toMouseEvent(event)->detail() <= 1));

+ return (event->type() == EventTypeNames::click || event->type() == EventTypeNames::auxclick) && (!event->isMouseEvent() || (toMouseEvent(event)->button() != RightButton && toMouseEvent(event)->detail() <= 1));

}

bool HTMLAnchorElement::willRespondToMouseClickEvents()