third_party/WebKit/Source/core/events/EventTarget.cpp - Issue 2163893003: Start sending auxclick instead of click for non-primary buttons

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/events/EventTarget.cpp

Issue 2163893003: Start sending auxclick instead of click for non-primary buttons (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Start sending auxclick instead of click for non-primary buttons Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/dom/GlobalEventHandlers.idl ('k') | third_party/WebKit/Source/core/events/EventTypeNames.in » ('j') | third_party/WebKit/Source/devtools/front_end/ui/TabbedPane.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/events/EventTarget.cpp

diff --git a/third_party/WebKit/Source/core/events/EventTarget.cpp b/third_party/WebKit/Source/core/events/EventTarget.cpp

index cd8b30c521c9f4219c1ad85a184bb37cbd7d4c27..5efe54a1fea00a4c6d0d0b5807fea9cfc7c6d39e 100644

--- a/third_party/WebKit/Source/core/events/EventTarget.cpp

+++ b/third_party/WebKit/Source/core/events/EventTarget.cpp

@@ -295,7 +295,11 @@ bool EventTarget::addEventListenerInternal(const AtomicString& eventType, EventL

void EventTarget::addedEventListener(const AtomicString& eventType, RegisteredEventListener& registeredListener)

{

- if (EventUtil::isPointerEventType(eventType)) {

+ if (eventType == EventTypeNames::auxclick) {

+ if (LocalDOMWindow* executingWindow = this->executingWindow()) {

+ UseCounter::count(executingWindow->document(), UseCounter::AuxclickAddListenerCount);

+ }

+ } else if (EventUtil::isPointerEventType(eventType)) {

if (LocalDOMWindow* executingWindow = this->executingWindow()) {

UseCounter::count(executingWindow->document(), UseCounter::PointerEventAddListenerCount);

}