Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2599)

Unified Diff: chrome/browser/ui/browser_browsertest.cc

Issue 2163893003: Start sending auxclick instead of click for non-primary buttons (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Another rebase Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/browser_browsertest.cc
diff --git a/chrome/browser/ui/browser_browsertest.cc b/chrome/browser/ui/browser_browsertest.cc
index ded8e2fe9de0c2beff89ad8d16c57fe550b01954..2e8ec2a2e051e7b7af0e15e61e148177bb662a7d 100644
--- a/chrome/browser/ui/browser_browsertest.cc
+++ b/chrome/browser/ui/browser_browsertest.cc
@@ -2460,28 +2460,6 @@ IN_PROC_BROWSER_TEST_F(ClickModifierTest, WindowOpenControlShiftClickTest) {
RunTest(browser(), GetWindowOpenURL(), modifiers, button, disposition);
}
-// Middle-clicks open in a background tab.
-#if defined(OS_LINUX)
-// http://crbug.com/396347
-#define MAYBE_WindowOpenMiddleClickTest DISABLED_WindowOpenMiddleClickTest
-#else
-#define MAYBE_WindowOpenMiddleClickTest WindowOpenMiddleClickTest
-#endif
-IN_PROC_BROWSER_TEST_F(ClickModifierTest, MAYBE_WindowOpenMiddleClickTest) {
- int modifiers = 0;
- blink::WebMouseEvent::Button button = blink::WebMouseEvent::ButtonMiddle;
- WindowOpenDisposition disposition = NEW_BACKGROUND_TAB;
- RunTest(browser(), GetWindowOpenURL(), modifiers, button, disposition);
-}
-
-// Shift-middle-clicks open in a foreground tab.
-IN_PROC_BROWSER_TEST_F(ClickModifierTest, WindowOpenShiftMiddleClickTest) {
- int modifiers = blink::WebInputEvent::ShiftKey;
- blink::WebMouseEvent::Button button = blink::WebMouseEvent::ButtonMiddle;
- WindowOpenDisposition disposition = NEW_FOREGROUND_TAB;
- RunTest(browser(), GetWindowOpenURL(), modifiers, button, disposition);
-}
-
// Tests for clicking on normal links.
IN_PROC_BROWSER_TEST_F(ClickModifierTest, HrefBasicClickTest) {
« no previous file with comments | « chrome/browser/resources/ntp4/new_tab.js ('k') | testing/buildbot/filters/browser-side-navigation.linux.browser_tests.filter » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698