Start sending auxclick instead of click for non-primary buttons

chrome/browser/resources/ntp4/nav_dot.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview Nav dot
  * This is the class for the navigation controls that appear along the bottom
  * of the NTP.
  */
 
@@ skipping 37 matching lines @@
       this.input_.value = title;
       // Take the input out of the tab-traversal focus order.
       this.input_.disabled = true;
       this.appendChild(this.input_);
 
       this.displayTitle = title;
       this.titleIsEditable_ = titleIsEditable;
 
       this.addEventListener('keydown', this.onKeyDown_);
       this.addEventListener('click', this.onClick_);
+      this.addEventListener('auxclick', this.onClick_);

[Dan Beam, 2016/08/09 02:04:34]

did people file bugs on your about not switching to the correct apps page when
/middle/-clicking a "nav dot"?  that seems kind of invalid to me...

[Navid Zolghadr, 2016/08/09 13:34:46]

There was no bug filed for this. This was one of the occurrences that I found
with search and fixed in the sense that I kept the previous behavior. Do you
think that behavior is not-wanted behavior of listening to the click that was
sent for all buttons?

[Dan Beam, 2016/08/09 16:22:54]

I think it's fine just to ignore auxiliary clicks for this particular thing.  I
wouldn't expect something useful to happen when middle clicking anywhere on the
page ;)

[Navid Zolghadr, 2016/08/10 14:32:09]

If I recall correctly there is this little functionality that will be changed.
There is this web store link in the bottom right of the apps page which if you
middle click normally would open the web store in a new tab. I believe removing
this would remove that functionality.

[Dan Beam, 2016/08/10 22:35:26]

see other comment

[Navid Zolghadr, 2016/08/11 16:11:03]

Removed it. I guess if any bug comes up later we can always add listeners.

       this.addEventListener('dblclick', this.onDoubleClick_);
       this.dragWrapper_ = new cr.ui.DragWrapper(this, this);
       this.addEventListener('webkitTransitionEnd', this.onTransitionEnd_);
 
       this.input_.addEventListener('blur', this.onInputBlur_.bind(this));
       this.input_.addEventListener('mousedown',
                                    this.onInputMouseDown_.bind(this));
       this.input_.addEventListener('keydown', this.onInputKeyDown_.bind(this));
 
       if (animate) {
@@ skipping 180 matching lines @@
     onTransitionEnd_: function(e) {
       if (e.propertyName === 'max-width' && this.classList.contains('small'))
         this.parentNode.removeChild(this);
     },
   };
 
   return {
     NavDot: NavDot,
   };
 });