Start sending auxclick instead of click for non-primary buttons

third_party/WebKit/Source/devtools/front_end/ui/treeoutline.js

 /*
  * Copyright (C) 2007 Apple Inc.  All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
@@ skipping 346 matching lines @@
     this.previousSibling = null;
     this.nextSibling = null;
 
     this._listItemNode = createElement("li");
     this._listItemNode.treeElement = this;
     if (title)
         this.title = title;
     this._listItemNode.addEventListener("mousedown", this._handleMouseDown.bind(this), false);
     this._listItemNode.addEventListener("selectstart", this._treeElementSelectStart.bind(this), false);
     this._listItemNode.addEventListener("click", this._treeElementToggled.bind(this), false);
-    this._listItemNode.addEventListener("dblclick", this._handleDoubleClick.bind(this), false);
+    this._listItemNode.addEventListener("auxclick", this._treeElementToggled.bind(this), false);

[dgozman, 2016/08/03 20:54:28]

Why change this? Are you going to stop sending dblclick events for main button
as well?

[Navid Zolghadr, 2016/08/03 21:35:20]

We stopped sending dblclick for middle button but not for primary (left) button.
There is this behavior for middle double click in devtools when you double
middle click an html attribute it selects the attribute name and the value
together as oppose to double clicking with left button which only selects the
value. Anyhow this way of handling dblclick would handle them both in one shot
and I thought it is cleaner to handle them both with the detail check. Is that
okay?

[dgozman, 2016/08/03 22:31:49]

I cannot repro the behavior you mention on linux. Perhaps, that's the default
"select on double click" behavior which differs between OSes? Judging by this
code, we have no special handling. I'd prefer to continue using dblclick, so
that double middle click doesn't do this.

[Navid Zolghadr, 2016/08/04 14:42:05]

Sure. done.

 
     this._childrenListNode = createElement("ol");
     this._childrenListNode.parentTreeElement = this;
     this._childrenListNode.classList.add("children");
 
     this._hidden = false;
     this._selectable = true;
     this.expanded = false;
     this.selected = false;
     this.setExpandable(expandable || false);
@@ skipping 399 matching lines @@
     {
         event.currentTarget._selectionStarted = true;
     },
 
     /**
      * @param {!Event} event
      */
     _treeElementToggled: function(event)
     {
         var element = event.currentTarget;
+
+        // Handling dblclick
+        if (event.detail === 2) {
+            if (!element || element.treeElement !== this)
+                return;
+
+            var handled = this.ondblclick(event);
+            if (handled)
+                return;
+            if (this._expandable && !this.expanded)
+                this.expand();
+            return;
+        }
+
         if (element._selectionStarted) {
             delete element._selectionStarted;
             var selection = element.getComponentSelection();
             if (selection && !selection.isCollapsed && element.isSelfOrAncestor(selection.anchorNode) && element.isSelfOrAncestor(selection.focusNode))
                 return;
         }
 
         if (element.treeElement !== this)
             return;
 
@@ skipping 33 matching lines @@
             return;
         if (element.treeElement !== this)
             return;
 
         if (this.isEventWithinDisclosureTriangle(event))
             return;
 
         this.selectOnMouseDown(event);
     },
 
-    /**
-     * @param {!Event} event
-     */
-    _handleDoubleClick: function(event)
-    {
-        var element = event.currentTarget;
-        if (!element || element.treeElement !== this)
-            return;
-
-        var handled = this.ondblclick(event);
-        if (handled)
-            return;
-        if (this._expandable && !this.expanded)
-            this.expand();
-    },
-
     _detach: function()
     {
         this._listItemNode.remove();
         this._childrenListNode.remove();
     },
 
     collapse: function()
     {
         if (!this.expanded || !this._collapsible)
             return;
@@ skipping 297 matching lines @@
     isEventWithinDisclosureTriangle: function(event)
     {
         // FIXME: We should not use getComputedStyle(). For that we need to get rid of using ::before for disclosure triangle. (http://webk.it/74446)
         var paddingLeftValue = window.getComputedStyle(this._listItemNode).paddingLeft;
         console.assert(paddingLeftValue.endsWith("px"));
         var computedLeftPadding = parseFloat(paddingLeftValue);
         var left = this._listItemNode.totalOffsetLeft() + computedLeftPadding;
         return event.pageX >= left && event.pageX <= left + TreeElement._ArrowToggleWidth && this._expandable;
     }
 }