Start sending auxclick instead of click for non-primary buttons

third_party/WebKit/Source/devtools/front_end/ui/TabbedPane.js

 /*
  * Copyright (C) 2010 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 1057 matching lines @@
         if (!measuring)
             this._titleElement = titleElement;
 
         if (this._closeable)
             tabElement.createChild("div", "tabbed-pane-close-button", "dt-close-button").gray = true;
 
         if (measuring) {
             tabElement.classList.add("measuring");
         } else {
             tabElement.addEventListener("click", this._tabClicked.bind(this), false);
+            tabElement.addEventListener("auxclick", this._tabClicked.bind(this), false);

[dgozman, 2016/07/27 20:30:43]

Note that if you stop sending regular click events for non-primary buttons, this
code deployed in the wild will break.

[Navid Zolghadr, 2016/07/27 20:39:09]

I was under the impression that this code in the wild gets updated with this
version of the Chrome as they are internal Chrome pages. So the change of not
sending the click for non-primary buttons will deploy along with the change to
this file. Am I right? or is there something else that I'm missing?

[dgozman, 2016/07/27 20:49:27]

We have old version in the cloud, which are used regularly, so this will break
them.

Anyway, this seems like breaking web platform compat. Did you send an intent to
remove to blink-dev?

[dtapuska, 2016/07/28 23:41:11]

We can probably polyfill for auxclick. Although you do need to detect somehow
that the code you downloaded from the cloud now supports auxclick so don't
re-dispatch the auxclick as a click event. Not entirely sure how the devtools
follows a pattern for that. Likewise the auxclick is runtime enabled; so that
polyfill would have to be handled somehow like that.

             tabElement.addEventListener("mousedown", this._tabMouseDown.bind(this), false);
             tabElement.addEventListener("mouseup", this._tabMouseUp.bind(this), false);
 
             tabElement.addEventListener("contextmenu", this._tabContextMenu.bind(this), false);
             if (this._tabbedPane._allowTabReorder)
                 WebInspector.installDragHandle(tabElement, this._startTabDragging.bind(this), this._tabDragging.bind(this), this._endTabDragging.bind(this), "-webkit-grabbing", "pointer", 200);
         }
 
         return tabElement;
     },
@@ skipping 364 matching lines @@
             if (this._viewCallback && view)
                 this._viewCallback(id, view);
             var shouldFocus = this._tabbedPane.visibleView.element.isSelfOrAncestor(WebInspector.currentFocusElement());
             this._tabbedPane.changeTabView(id, view);
             if (shouldFocus)
                 view.focus();
             return view;
         }
     }
 }