Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Unified Diff: third_party/WebKit/Source/core/dom/Document.cpp

Issue 2163893002: Avoid calling isFocusable() during updateLayout. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: layout test Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/fast/dom/focus-and-update-layout-crash.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/dom/Document.cpp
diff --git a/third_party/WebKit/Source/core/dom/Document.cpp b/third_party/WebKit/Source/core/dom/Document.cpp
index aba34c010cce40e02c43c75f28d7b7a799a3c027..bb0c8e5d62330d725e1c9eb5500c898d7c221451 100644
--- a/third_party/WebKit/Source/core/dom/Document.cpp
+++ b/third_party/WebKit/Source/core/dom/Document.cpp
@@ -1731,7 +1731,7 @@ void Document::updateStyleAndLayoutTree()
if (hoverNode() && !hoverNode()->layoutObject() && frame())
frame()->eventHandler().dispatchFakeMouseMoveEventSoon();
- if (m_focusedElement && !m_focusedElement->isFocusable())
tkent 2016/07/21 00:38:50 At this line, we already updated style and layout
kochi 2016/07/21 01:32:49 Hmm, yes. Yesterday I saw another case that needsU
+ if (m_focusedElement)
esprehn 2016/07/23 08:37:25 Note that we can't land this change anyway, since
clearFocusedElementSoon();
layoutViewItem().clearHitTestCache();
« no previous file with comments | « third_party/WebKit/LayoutTests/fast/dom/focus-and-update-layout-crash.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698