Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(389)

Issue 2163883009: MD Settings: drop :hover shadow from avatar selector (Closed)

Created:
4 years, 5 months ago by Dan Beam
Modified:
4 years, 5 months ago
Reviewers:
tommycli
CC:
chromium-reviews, dbeam+watch-elements_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, dbeam+watch-settings_chromium.org, michaelpg+watch-elements_chromium.org, stevenjb+watch-md-settings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: drop :hover shadow from avatar selector R=tommycli@chromium.org BUG=630067 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/f52ee40fe6da910d2ff09c94df74a53230bcff44 Cr-Commit-Position: refs/heads/master@{#406896}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -7 lines) Patch
M chrome/browser/resources/settings/people_page/manage_profile.html View 1 chunk +0 lines, -3 lines 1 comment Download
M ui/webui/resources/cr_elements/cr_profile_avatar_selector/cr_profile_avatar_selector.html View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Dan Beam
https://codereview.chromium.org/2163883009/diff/1/chrome/browser/resources/settings/people_page/manage_profile.html File chrome/browser/resources/settings/people_page/manage_profile.html (left): https://codereview.chromium.org/2163883009/diff/1/chrome/browser/resources/settings/people_page/manage_profile.html#oldcode15 chrome/browser/resources/settings/people_page/manage_profile.html:15: }; fun fact, I believe: --avatar-selector-avatar-hovered: var(--shadow-elevation-2dp); might accomplish ...
4 years, 5 months ago (2016-07-21 02:11:28 UTC) #2
tommycli
lgtm
4 years, 5 months ago (2016-07-21 17:44:45 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2163883009/1
4 years, 5 months ago (2016-07-21 17:52:26 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-21 17:56:05 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-21 17:58:40 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f52ee40fe6da910d2ff09c94df74a53230bcff44
Cr-Commit-Position: refs/heads/master@{#406896}

Powered by Google App Engine
This is Rietveld 408576698