Fix the clipboard feature spec.

Fix the clipboard feature spec.

BUG=460610
Committed: https://crrev.com/823d1b17ae260c1e167421b2c5ee64cfa9370a73
Cr-Commit-Position: refs/heads/master@{#406724}

[jennyz, 2016-07-20 22:13:06]

Description was changed from

==========
Fix the clipboard feature spec.

BUG=460610
==========

to

==========
Fix the clipboard feature spec.

BUG=460610
==========

[jennyz, 2016-07-20 22:13:06]

jennyz@chromium.org changed reviewers:
+ rdevlin.cronin@chromium.org

[Devlin, 2016-07-20 22:40:31]

lgtm

https://codereview.chromium.org/2163883006/diff/1/extensions/common/api/_api_...
File extensions/common/api/_api_features.json (right):

https://codereview.chromium.org/2163883006/diff/1/extensions/common/api/_api_...
extensions/common/api/_api_features.json:153: "clipboard": [{
features that have only one entry should not be a list, but rather a dictionary
(so remove the [] around the definition).

https://codereview.chromium.org/2163883006/diff/1/extensions/common/api/_api_...
extensions/common/api/_api_features.json:154: "channel": "dev",
the clipboard permission is already restricted to dev channel, so you don't need
to specify that here as well.  Ditto for extension_types.

https://codereview.chromium.org/2163883006/diff/1/extensions/common/api/_api_...
extensions/common/api/_api_features.json:157: "platforms": ["chromeos"],
Though there's no rule behind it, we typically put high-level, API-wide
restrictions like platforms, extension types, and channel in the
_permissions_features.json file, and then depend on that here.  Please move this
restriction to that file.  (Note there is an exception if a specific API method
is only available on a certain platform, as is the case with e.g. the
bluetoothLowEnergy entries above.)

[Devlin, 2016-07-20 22:40:51]

gah, hit the wrong button. not lg quite yet, I'd like to take another look
before committing

[jennyz, 2016-07-20 23:22:48]

https://codereview.chromium.org/2163883006/diff/1/extensions/common/api/_api_...
File extensions/common/api/_api_features.json (right):

https://codereview.chromium.org/2163883006/diff/1/extensions/common/api/_api_...
extensions/common/api/_api_features.json:153: "clipboard": [{
On 2016/07/20 22:40:31, Devlin wrote:
> features that have only one entry should not be a list, but rather a
dictionary
> (so remove the [] around the definition).

Done.

https://codereview.chromium.org/2163883006/diff/1/extensions/common/api/_api_...
extensions/common/api/_api_features.json:154: "channel": "dev",
On 2016/07/20 22:40:31, Devlin wrote:
> the clipboard permission is already restricted to dev channel, so you don't
need
> to specify that here as well.  Ditto for extension_types.

Done.

https://codereview.chromium.org/2163883006/diff/1/extensions/common/api/_api_...
extensions/common/api/_api_features.json:157: "platforms": ["chromeos"],
On 2016/07/20 22:40:31, Devlin wrote:
> Though there's no rule behind it, we typically put high-level, API-wide
> restrictions like platforms, extension types, and channel in the
> _permissions_features.json file, and then depend on that here.  Please move
this
> restriction to that file.  (Note there is an exception if a specific API
method
> is only available on a certain platform, as is the case with e.g. the
> bluetoothLowEnergy entries above.)

Done.

[Devlin, 2016-07-20 23:26:58]

lgtm % nit

https://codereview.chromium.org/2163883006/diff/20001/extensions/common/api/_...
File extensions/common/api/_api_features.json (right):

https://codereview.chromium.org/2163883006/diff/20001/extensions/common/api/_...
extensions/common/api/_api_features.json:153: "clipboard": {
Looks like you have trailing spaces here?

[jennyz, 2016-07-20 23:33:15]

The CQ bit was checked by jennyz@chromium.org

[jennyz, 2016-07-20 23:33:16]

The patchset sent to the CQ was uploaded after l-g-t-m from
rdevlin.cronin@chromium.org
Link to the patchset: https://codereview.chromium.org/2163883006/#ps40001
(title: "Fix a nit.")

[commit-bot: I haz the power, 2016-07-20 23:33:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jennyz, 2016-07-20 23:43:55]

https://codereview.chromium.org/2163883006/diff/20001/extensions/common/api/_...
File extensions/common/api/_api_features.json (right):

https://codereview.chromium.org/2163883006/diff/20001/extensions/common/api/_...
extensions/common/api/_api_features.json:153: "clipboard": {
On 2016/07/20 23:26:58, Devlin wrote:
> Looks like you have trailing spaces here?

Done.

[commit-bot: I haz the power, 2016-07-21 00:20:21]

Description was changed from

==========
Fix the clipboard feature spec.

BUG=460610
==========

to

==========
Fix the clipboard feature spec.

BUG=460610
==========

[commit-bot: I haz the power, 2016-07-21 00:20:22]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-07-21 00:22:20]

Description was changed from

==========
Fix the clipboard feature spec.

BUG=460610
==========

to

==========
Fix the clipboard feature spec.

BUG=460610

Committed: https://crrev.com/823d1b17ae260c1e167421b2c5ee64cfa9370a73
Cr-Commit-Position: refs/heads/master@{#406724}
==========

[commit-bot: I haz the power, 2016-07-21 00:22:22]

Patchset 3 (id:??) landed as
https://crrev.com/823d1b17ae260c1e167421b2c5ee64cfa9370a73
Cr-Commit-Position: refs/heads/master@{#406724}