Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(416)

Unified Diff: net/quic/quic_http_stream.cc

Issue 2163883004: Do not invoke QuicHttpStream::DoCallback when in DoLoop (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add a test which crashes with the exact call stack without the patch Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/quic/quic_http_stream_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_http_stream.cc
diff --git a/net/quic/quic_http_stream.cc b/net/quic/quic_http_stream.cc
index 39784fe2c5828246f32c81a4cd7b8e699e7d8134..fb2b798eac890bc90b2897ed477ee79ff9fe28db 100644
--- a/net/quic/quic_http_stream.cc
+++ b/net/quic/quic_http_stream.cc
@@ -510,6 +510,10 @@ void QuicHttpStream::OnClose() {
quic_connection_error_ = stream_->connection_error();
ResetStream();
+ if (in_loop_) {
+ // If already in DoLoop(), |callback_| will be handled when DoLoop() exits.
+ return;
+ }
Ryan Hamilton 2016/07/21 22:29:33 Do you know what state in DoLoop we're in when thi
xunjieli 2016/07/22 13:21:22 According to the crash log on crbug/629043, we are
if (!callback_.is_null()) {
DoCallback(response_status_);
}
« no previous file with comments | « no previous file | net/quic/quic_http_stream_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698