Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Unified Diff: tools/mb/mb.py

Issue 2163833003: Logdog for logcats (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments cont. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/mb/mb.py
diff --git a/tools/mb/mb.py b/tools/mb/mb.py
index c21e2f10879f11ee85bc4d03fac9fbd5cfc35a13..0583111720be53e8cf86d15b0e018be440042d17 100755
--- a/tools/mb/mb.py
+++ b/tools/mb/mb.py
@@ -1010,12 +1010,24 @@ class MetaBuildWrapper(object):
extra_files = []
if android and test_type != "script":
- cmdline = [
+ logdog_command = [
+ '--logdog-bin-cmd', './../../bin/logdog_butler',
+ '--project', 'chromium',
+ '--output', 'logdog,host=luci-logdog-dev.appspot.com',
+ '--service-account-json',
+ '/creds/service_accounts/service-account-luci-logdog-publisher.json',
+ '--prefix', 'android/swarming/logcats/${SWARMING_TASK_ID}',
+ '--source', '${ISOLATED_OUTDIR}/logcats',
+ '--name', 'unified_logcats',
+ ]
+ test_cmdline = [
self.PathJoin('bin', 'run_%s' % target_name),
- '--logcat-output-dir', '${ISOLATED_OUTDIR}/logcats',
+ '--logcat-output-file', '${ISOLATED_OUTDIR}/logcats',
'--target-devices-file', '${SWARMING_BOT_FILE}',
- '-v',
+ '-v'
]
+ cmdline = (['./../../build/android/test_wrapper/test_runner_wrapper.py'] +
+ logdog_command + test_cmdline)
elif use_x11 and test_type == 'windowed_test_launcher':
extra_files = [
'xdisplaycheck',
« testing/buildbot/chromium.android.json ('K') | « testing/buildbot/chromium.linux.json ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698