Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Unified Diff: tools/mb/mb.py

Issue 2163833003: Logdog for logcats (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Try new test runner format Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/mb/mb.py
diff --git a/tools/mb/mb.py b/tools/mb/mb.py
index 3ee71030d0086462afe125bf4064fb3a4a160b00..eac9abefe7cb61f482a28d3608dbc3b168014d8e 100755
--- a/tools/mb/mb.py
+++ b/tools/mb/mb.py
@@ -995,11 +995,24 @@ class MetaBuildWrapper(object):
extra_files = []
if android and test_type != "script":
+ logdog_command = [
+ './../../bin/logdog_butler',
+ '-project', 'chromium',
+ '-output', 'logdog,host=luci-logdog-dev.appspot.com',
+ '-prefix', 'android/swarming/logcats/${SWARMING_TASK_ID}',
+ #'-service-account-json',
ghost stip (do not use) 2016/07/20 22:24:23 why the commented out code?
nicholaslin 2016/07/23 01:23:21 These credentials are for the production luci-logd
+ #'/creds/service_accounts/service-account-luci-logdog-publisher.json'
+# ]
+# stream_command = [
+ 'stream', '-source', '${ISOLATED_OUTDIR}/logcats',
+ ]
cmdline = [
self.PathJoin('bin', 'run_%s' % target_name),
- '--logcat-output-dir', '${ISOLATED_OUTDIR}/logcats',
+ '--logcat-output-file', '${ISOLATED_OUTDIR}/logcats',
'--target-devices-file', '${SWARMING_BOT_FILE}',
- '-v',
+ '--logdog-command', ' '.join(logdog_command),
+# '--logdog-stream', ' '.join(stream_command),
+ '-v'
]
elif use_x11 and test_type == 'windowed_test_launcher':
extra_files = [

Powered by Google App Engine
This is Rietveld 408576698