Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 2163823004: [runtime] cleanup: use the factory() for handlified values (Closed)

Created:
4 years, 5 months ago by Camillo Bruni
Modified:
4 years, 5 months ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[runtime] cleanup: use the factory() for handlified values BUG= Committed: https://crrev.com/5afb2f7a122cd1b4fd358d84939306d9c731b541 Cr-Commit-Position: refs/heads/master@{#37981}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/runtime/runtime-debug.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/runtime-generator.cc View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 8 (3 generated)
Camillo Bruni
PTAL very small cleanup
4 years, 5 months ago (2016-07-21 11:26:08 UTC) #2
Jakob Kummerow
lgtm
4 years, 5 months ago (2016-07-21 14:10:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2163823004/1
4 years, 5 months ago (2016-07-22 12:03:01 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-22 12:22:40 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-07-22 12:26:11 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5afb2f7a122cd1b4fd358d84939306d9c731b541
Cr-Commit-Position: refs/heads/master@{#37981}

Powered by Google App Engine
This is Rietveld 408576698