Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(393)

Unified Diff: chrome/browser/safe_browsing/incident_reporting/environment_data_collection_win.cc

Issue 2163803003: [chrome_elf] Removing blacklist finch for dynamic dll changes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Review fixes. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/safe_browsing/incident_reporting/environment_data_collection_win_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/safe_browsing/incident_reporting/environment_data_collection_win.cc
diff --git a/chrome/browser/safe_browsing/incident_reporting/environment_data_collection_win.cc b/chrome/browser/safe_browsing/incident_reporting/environment_data_collection_win.cc
index bb067db15f2841c992666181725d2b6e30a729bf..f29de2b8d3b9e96869b24172dada498cc9962a37 100644
--- a/chrome/browser/safe_browsing/incident_reporting/environment_data_collection_win.cc
+++ b/chrome/browser/safe_browsing/incident_reporting/environment_data_collection_win.cc
@@ -234,18 +234,6 @@ void RecordLspFeature(ClientIncidentReport_EnvironmentData_Process* process) {
}
}
-void CollectDllBlacklistData(
- ClientIncidentReport_EnvironmentData_Process* process) {
- PathSanitizer path_sanitizer;
- base::win::RegistryValueIterator iter(HKEY_CURRENT_USER,
- blacklist::kRegistryFinchListPath);
- for (; iter.Valid(); ++iter) {
- base::FilePath dll_name(iter.Value());
- path_sanitizer.StripHomeDirectory(&dll_name);
- process->add_blacklisted_dll(dll_name.AsUTF8Unsafe());
- }
-}
-
void CollectModuleVerificationData(
const wchar_t* const modules_to_verify[],
size_t num_modules_to_verify,
@@ -311,7 +299,6 @@ void CollectPlatformProcessData(
ClientIncidentReport_EnvironmentData_Process* process) {
CollectDlls(process);
RecordLspFeature(process);
- CollectDllBlacklistData(process);
CollectModuleVerificationData(
kModulesToVerify, arraysize(kModulesToVerify), process);
}
« no previous file with comments | « no previous file | chrome/browser/safe_browsing/incident_reporting/environment_data_collection_win_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698