[chrome_elf] Removing blacklist finch for dynamic dll changes.

chrome/installer/setup/uninstall.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // This file defines the methods useful for uninstalling Chrome.
 
 #include "chrome/installer/setup/uninstall.h"
 
 #include <windows.h>
 #include <stddef.h>
@@ skipping 768 matching lines @@
 
 // Removes the persistent blacklist state for the current user.  Note: this will
 // not remove the state for users other than the one uninstalling Chrome on a
 // system-level install (http://crbug.com/388725). Doing so would require
 // extracting the per-user registry hive iteration from
 // UninstallActiveSetupEntries so that it could service multiple tasks.
 void RemoveBlacklistState() {
   InstallUtil::DeleteRegistryKey(HKEY_CURRENT_USER,
                                  blacklist::kRegistryBeaconPath,
                                  0);  // wow64_access
-  InstallUtil::DeleteRegistryKey(HKEY_CURRENT_USER,
-                                 blacklist::kRegistryFinchListPath,
-                                 0);  // wow64_access

[robertshield, 2016/07/22 02:37:52]

I reckon we should leave this bit here for now. As people upgrade they may still
have the old key, we should make a best effort to clear it up for the
foreseeable future.

Consider adding a comment that this deletion is to clean up some legacy code
though.

[penny, 2016/07/27 22:55:52]

Done.  I figured that anyone with a current install will have the cleanup code
in their current install.  But I agree that it's safer/cleaner to leave it in
for a while.

 }
 
 // Removes the persistent state for |distribution| for the current user. Note:
 // this will not remove the state for users other than the one uninstalling
 // Chrome on a system-level install; see RemoveBlacklistState for details.
 void RemoveDistributionRegistryState(BrowserDistribution* distribution) {
   // Binaries do not store per-user state.
   if (distribution->GetType() != BrowserDistribution::CHROME_BINARIES) {
     static const base::char16* const kKeysToPreserve[] = {
         L"Extensions",
@@ skipping 568 matching lines @@
     // If we need a reboot to continue, schedule the parent directories for
     // deletion unconditionally. If they are not empty, the session manager
     // will not delete them on reboot.
     ScheduleParentAndGrandparentForDeletion(target_path);
   } else if (DeleteChromeDirectoriesIfEmpty(target_path) == DELETE_FAILED) {
     *uninstall_status = UNINSTALL_FAILED;
   }
 }
 
 }  // namespace installer