[chrome_elf] Removing blacklist finch for dynamic dll changes.

chrome/browser/safe_browsing/incident_reporting/environment_data_collection_win_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/safe_browsing/incident_reporting/environment_data_collection_win.h"
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include <algorithm>
@@ skipping 11 matching lines @@
 #include "chrome/browser/safe_browsing/path_sanitizer.h"
 #include "chrome/common/safe_browsing/csd.pb.h"
 #include "chrome_elf/chrome_elf_constants.h"
 #include "net/base/winsock_init.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace safe_browsing {
 
 namespace {
 
-const wchar_t test_dll[] = L"test_name.dll";
-
 // Returns true if a dll with filename |dll_name| is found in |process_report|,
 // providing a copy of it in |result|.
 bool GetProcessReportDll(
     const ClientIncidentReport_EnvironmentData_Process& process_report,
     const base::FilePath& dll_name,
     ClientIncidentReport_EnvironmentData_Process_Dll* result) {
   for (const auto& dll : process_report.dll()) {
     if (base::FilePath::FromUTF8Unsafe(dll.path()).BaseName() == dll_name) {
       result->CopyFrom(dll);
       return true;
@@ skipping 74 matching lines @@
 
   RecordLspFeature(&process_report);
 
   // Return successfully if LSP feature is found.
   if (DllEntryContainsLspFeature(process_report, lsp))
     return;
 
   FAIL() << "No LSP feature found for " << lsp;
 }
 
-TEST(SafeBrowsingEnvironmentDataCollectionWinTest, CollectDllBlacklistData) {
-  // Ensure that CollectDllBlacklistData correctly adds the set of sanitized dll
-  // names currently stored in the registry to the report.
-  registry_util::RegistryOverrideManager override_manager;
-  override_manager.OverrideRegistry(HKEY_CURRENT_USER);
-
-  base::win::RegKey blacklist_registry_key(HKEY_CURRENT_USER,
-                                           blacklist::kRegistryFinchListPath,
-                                           KEY_QUERY_VALUE | KEY_SET_VALUE);
-
-  // Check that with an empty registry the blacklisted dlls field is left empty.
-  ClientIncidentReport_EnvironmentData_Process process_report;
-  CollectDllBlacklistData(&process_report);
-  EXPECT_EQ(0, process_report.blacklisted_dll_size());
-
-  // Check that after adding exactly one dll to the registry it appears in the
-  // process report.
-  blacklist_registry_key.WriteValue(test_dll, test_dll);
-  CollectDllBlacklistData(&process_report);
-  ASSERT_EQ(1, process_report.blacklisted_dll_size());
-
-  base::string16 process_report_dll =
-      base::UTF8ToWide(process_report.blacklisted_dll(0));
-  EXPECT_EQ(base::string16(test_dll), process_report_dll);
-
-  // Check that if the registry contains the full path to a dll it is properly
-  // sanitized before being reported.
-  blacklist_registry_key.DeleteValue(test_dll);
-  process_report.clear_blacklisted_dll();
-
-  base::FilePath path;
-  ASSERT_TRUE(PathService::Get(base::DIR_HOME, &path));
-  base::string16 input_path =
-      path.Append(FILE_PATH_LITERAL("test_path.dll")).value();
-
-  std::string path_expected = base::FilePath(FILE_PATH_LITERAL("~"))
-                                  .Append(FILE_PATH_LITERAL("test_path.dll"))
-                                  .AsUTF8Unsafe();
-
-  blacklist_registry_key.WriteValue(input_path.c_str(), input_path.c_str());
-  CollectDllBlacklistData(&process_report);
-
-  ASSERT_EQ(1, process_report.blacklisted_dll_size());
-  std::string process_report_path = process_report.blacklisted_dll(0);
-  EXPECT_EQ(path_expected, process_report_path);
-}
-
 #if !defined(_WIN64)
 TEST(SafeBrowsingEnvironmentDataCollectionWinTest, VerifyLoadedModules) {
   //  Load the test modules.
   std::vector<base::ScopedNativeLibrary> test_dlls(kTestDllNamesCount);
   for (size_t i = 0; i < kTestDllNamesCount; ++i) {
     test_dlls[i].Reset(
         LoadNativeLibrary(base::FilePath(kTestDllNames[i]), NULL));
   }
 
   // Edit the first byte of the function exported by the first module. Calling
@@ skipping 127 matching lines @@
 TEST(SafeBrowsingEnvironmentDataCollectionWinTest,
      CollectDomainEnrollmentData) {
   // The test may or may not be running on a domain-enrolled machine, so all we
   // can check is that some value is filled in.
   ClientIncidentReport_EnvironmentData_OS os_data;
   CollectDomainEnrollmentData(&os_data);
   EXPECT_TRUE(os_data.has_is_enrolled_to_domain());
 }
 
 }  // namespace safe_browsing