third_party/WebKit/Source/devtools/front_end/sdk/ConsoleModel.js - Issue 2163803002: [DevTools] Make WebInspector.ConsoleMessage 0-based

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/sdk/ConsoleModel.js

Issue 2163803002: [DevTools] Make WebInspector.ConsoleMessage 0-based (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js ('k') | third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/sdk/ConsoleModel.js

diff --git a/third_party/WebKit/Source/devtools/front_end/sdk/ConsoleModel.js b/third_party/WebKit/Source/devtools/front_end/sdk/ConsoleModel.js

index fa6e543c1ef80733472cedebb8a922e75fd77b2c..f1ad0fd31e048f08cf16dedc260f95b208bac419 100644

--- a/third_party/WebKit/Source/devtools/front_end/sdk/ConsoleModel.js

+++ b/third_party/WebKit/Source/devtools/front_end/sdk/ConsoleModel.js

@@ -285,7 +285,7 @@ WebInspector.ConsoleMessage = function(target, source, level, messageText, type,

this.stackTrace = initiator.stack || undefined;

if (initiator.url) {

this.url = initiator.url;

- this.line = initiator.lineNumber || 0;

+ this.line = (initiator.lineNumber - 1) || 0;

}

@@ -523,7 +523,7 @@ WebInspector.LogDispatcher.prototype = {

payload.text,

undefined,

payload.url,

- typeof payload.lineNumber === "undefined" ? undefined : payload.lineNumber + 1,

+ typeof payload.lineNumber === "undefined" ? undefined : payload.lineNumber,

dgozman 2016/07/20 00:59:14 Can just pass payload.lineNumber.

kozy 2016/07/20 01:11:50 Done.

undefined,

payload.networkRequestId,

undefined,