Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js

Issue 2163803002: [DevTools] Make WebInspector.ConsoleMessage 0-based (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: addressed comments Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved. 3 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved.
4 * Copyright (C) 2009 Joseph Pecoraro 4 * Copyright (C) 2009 Joseph Pecoraro
5 * 5 *
6 * Redistribution and use in source and binary forms, with or without 6 * Redistribution and use in source and binary forms, with or without
7 * modification, are permitted provided that the following conditions 7 * modification, are permitted provided that the following conditions
8 * are met: 8 * are met:
9 * 9 *
10 * 1. Redistributions of source code must retain the above copyright 10 * 1. Redistributions of source code must retain the above copyright
(...skipping 249 matching lines...) Expand 10 before | Expand all | Expand 10 after
260 * @param {string} url 260 * @param {string} url
261 * @param {number} lineNumber 261 * @param {number} lineNumber
262 * @param {number} columnNumber 262 * @param {number} columnNumber
263 * @return {?Element} 263 * @return {?Element}
264 */ 264 */
265 _linkifyLocation: function(url, lineNumber, columnNumber) 265 _linkifyLocation: function(url, lineNumber, columnNumber)
266 { 266 {
267 var target = this._target(); 267 var target = this._target();
268 if (!target) 268 if (!target)
269 return null; 269 return null;
270 // FIXME(62725): stack trace line/column numbers are one-based.
271 lineNumber = lineNumber ? lineNumber - 1 : 0;
272 columnNumber = columnNumber ? columnNumber - 1 : 0;
273 return this._linkifier.linkifyScriptLocation(target, null, url, lineNumb er, columnNumber, "console-message-url"); 270 return this._linkifier.linkifyScriptLocation(target, null, url, lineNumb er, columnNumber, "console-message-url");
274 }, 271 },
275 272
276 /** 273 /**
277 * @param {!RuntimeAgent.StackTrace} stackTrace 274 * @param {!RuntimeAgent.StackTrace} stackTrace
278 * @return {?Element} 275 * @return {?Element}
279 */ 276 */
280 _linkifyStackTraceTopFrame: function(stackTrace) 277 _linkifyStackTraceTopFrame: function(stackTrace)
281 { 278 {
282 var target = this._target(); 279 var target = this._target();
283 if (!target) 280 if (!target)
284 return null; 281 return null;
285 return this._linkifier.linkifyStackTraceTopFrame(target, stackTrace, "co nsole-message-url"); 282 return this._linkifier.linkifyStackTraceTopFrame(target, stackTrace, "co nsole-message-url");
286 }, 283 },
287 284
288 /** 285 /**
289 * @param {string} scriptId 286 * @param {string} scriptId
290 * @param {string} url 287 * @param {string} url
291 * @param {number} lineNumber 288 * @param {number} lineNumber
292 * @param {number} columnNumber 289 * @param {number} columnNumber
293 * @return {?Element} 290 * @return {?Element}
294 */ 291 */
295 _linkifyScriptId: function(scriptId, url, lineNumber, columnNumber) 292 _linkifyScriptId: function(scriptId, url, lineNumber, columnNumber)
296 { 293 {
297 var target = this._target(); 294 var target = this._target();
298 if (!target) 295 if (!target)
299 return null; 296 return null;
300 // FIXME(62725): stack trace line/column numbers are one-based.
301 lineNumber = lineNumber ? lineNumber - 1 : 0;
302 columnNumber = columnNumber ? columnNumber - 1 : 0;
303 return this._linkifier.linkifyScriptLocation(target, scriptId, url, line Number, columnNumber, "console-message-url"); 297 return this._linkifier.linkifyScriptLocation(target, scriptId, url, line Number, columnNumber, "console-message-url");
304 }, 298 },
305 299
306 _format: function(parameters) 300 _format: function(parameters)
307 { 301 {
308 // This node is used like a Builder. Values are continually appended ont o it. 302 // This node is used like a Builder. Values are continually appended ont o it.
309 var formattedResult = createElement("span"); 303 var formattedResult = createElement("span");
310 if (!parameters.length) 304 if (!parameters.length)
311 return formattedResult; 305 return formattedResult;
312 306
(...skipping 1050 matching lines...) Expand 10 before | Expand all | Expand 10 after
1363 { 1357 {
1364 if (!this._wrapperElement) { 1358 if (!this._wrapperElement) {
1365 WebInspector.ConsoleViewMessage.prototype.toMessageElement.call(this ); 1359 WebInspector.ConsoleViewMessage.prototype.toMessageElement.call(this );
1366 this._wrapperElement.classList.toggle("collapsed", this._collapsed); 1360 this._wrapperElement.classList.toggle("collapsed", this._collapsed);
1367 } 1361 }
1368 return this._wrapperElement; 1362 return this._wrapperElement;
1369 }, 1363 },
1370 1364
1371 __proto__: WebInspector.ConsoleViewMessage.prototype 1365 __proto__: WebInspector.ConsoleViewMessage.prototype
1372 } 1366 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698