Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Unified Diff: mojom/generators/c/cgen/type_translation.go

Issue 2163793002: C bindings: Implement _Validate(), and some pre-requisites (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: share common validation utility code between c/c++ tests. remove generating __HasResponse for inte… Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojom/generators/c/cgen/type_translation.go
diff --git a/mojom/generators/c/cgen/type_translation.go b/mojom/generators/c/cgen/type_translation.go
index 089da9e1031071144de8db936f4bf3068676b283..3fc69b4d5033ca49bebe1bd7a5dee3b6e3bec90b 100644
--- a/mojom/generators/c/cgen/type_translation.go
+++ b/mojom/generators/c/cgen/type_translation.go
@@ -267,7 +267,8 @@ func mojomTypeIsUnion(typ mojom_types.Type, fileGraph *mojom_files.MojomFileGrap
return false
}
-func mojomTypeSize(typ mojom_types.Type, fileGraph *mojom_files.MojomFileGraph) uint32 {
+// Returns the inlined (in a struct or array) size of a type in bytes.
+func mojomTypeByteSize(typ mojom_types.Type, fileGraph *mojom_files.MojomFileGraph) uint32 {
switch typ.(type) {
case *mojom_types.TypeSimpleType:
switch typ.Interface().(mojom_types.SimpleType) {
@@ -312,6 +313,7 @@ func mojomTypeSize(typ mojom_types.Type, fileGraph *mojom_files.MojomFileGraph)
return 0
}
+// Returns the inlined (in a struct or array) size of a reference type.
func referenceTypeSize(typ mojom_types.TypeReference, fileGraph *mojom_files.MojomFileGraph) uint32 {
if typ.IsInterfaceRequest {
return 4
@@ -331,3 +333,16 @@ func referenceTypeSize(typ mojom_types.TypeReference, fileGraph *mojom_files.Moj
log.Fatal("Uhoh, should not be here.", udt.Interface())
return 0
}
+
+// Same as mojomTypeByteSize, but in bits.
+func mojomTypeBitSize(typ mojom_types.Type, fileGraph *mojom_files.MojomFileGraph) uint32 {
+ switch typ.(type) {
+ case *mojom_types.TypeSimpleType:
+ switch typ.Interface().(mojom_types.SimpleType) {
+ case mojom_types.SimpleType_Bool:
+ return 1
+ }
+ }
+
+ return 8 * mojomTypeByteSize(typ, fileGraph)
+}

Powered by Google App Engine
This is Rietveld 408576698