Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(763)

Unified Diff: mojo/public/cpp/bindings/tests/BUILD.gn

Issue 2163793002: C bindings: Implement _Validate(), and some pre-requisites (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: share common validation utility code between c/c++ tests. remove generating __HasResponse for inte… Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/public/cpp/bindings/tests/BUILD.gn
diff --git a/mojo/public/cpp/bindings/tests/BUILD.gn b/mojo/public/cpp/bindings/tests/BUILD.gn
index 143ab490bcbfb5f3dae66e0c3efcbcee59c63635..4bbbc3f4dda8e5e96b5c0634185b6397ce36ee10 100644
--- a/mojo/public/cpp/bindings/tests/BUILD.gn
+++ b/mojo/public/cpp/bindings/tests/BUILD.gn
@@ -48,6 +48,7 @@ mojo_sdk_source_set("tests") {
deps = [
":mojo_public_bindings_test_utils",
+ ":validation_util",
"//testing/gtest",
]
@@ -95,6 +96,25 @@ mojo_sdk_source_set("mojo_public_bindings_test_utils") {
mojo_sdk_deps = [ "mojo/public/c/system" ]
}
+mojo_sdk_source_set("validation_util") {
viettrungluu 2016/07/28 23:03:01 Do you really need a separate target here, instead
vardhan 2016/07/29 21:29:22 yeah, i tried this initially :( mojo_public_bindin
viettrungluu 2016/08/01 21:17:19 Blech. Not having a gtest dependency seems reasona
vardhan 2016/08/01 22:18:16 Done.
+ testonly = true
+
+ sources = [
+ "validation_util.cc",
+ "validation_util.h",
+ ]
+
+ mojo_sdk_deps = [
+ "mojo/public/c/system",
+ "mojo/public/cpp/test_support",
+ ]
+
+ deps = [
+ ":mojo_public_bindings_test_utils",
+ "//testing/gtest",
+ ]
+}
+
mojo_native_application("versioning_test_service") {
testonly = true

Powered by Google App Engine
This is Rietveld 408576698