Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 2163783002: [Merge M53] Run autofill-profile de-dupe after sync starts if sync is enabled. (Closed)

Created:
4 years, 5 months ago by Mathieu
Modified:
4 years, 5 months ago
Reviewers:
Mathieu, sebsg
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2785
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

[Merge M53] Run autofill-profile de-dupe after sync starts if sync is enabled. This CL updates the PersonalDataManager to run autofill profile de-duplication (if enabled) at the appropriate time, depending on whether autofill profile sync is enabled. If sync is not enabled, profile de-duplication is run after the data is initially loaded. If sync is enabled, profild de-duplication is run after the sync first becomes active. In all cases, de-duplication is only run once for a given version of chromium. BUG=627519 R=sebsg@chromium.org, mathp@chromium.org Review-Url: https://codereview.chromium.org/2142123002 Cr-Commit-Position: refs/heads/master@{#406026} (cherry picked from commit d594dc5f82b5836f5f0b4ba8d52b8563ff3c2f27) Committed: https://chromium.googlesource.com/chromium/src/+/23f01b8469b9a91180398faf2ac9feb687b2ef6e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+194 lines, -44 lines) Patch
M components/autofill/core/browser/autofill_manager.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M components/autofill/core/browser/autofill_profile.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M components/autofill/core/browser/autofill_profile_comparator.cc View 2 chunks +33 lines, -8 lines 0 comments Download
M components/autofill/core/browser/personal_data_manager.h View 3 chunks +13 lines, -0 lines 0 comments Download
M components/autofill/core/browser/personal_data_manager.cc View 6 chunks +40 lines, -7 lines 0 comments Download
M components/autofill/core/browser/personal_data_manager_unittest.cc View 7 chunks +7 lines, -5 lines 0 comments Download
M components/autofill/core/browser/webdata/autocomplete_syncable_service.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M components/autofill/core/browser/webdata/autofill_data_type_controller_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M components/autofill/core/browser/webdata/autofill_profile_syncable_service.cc View 2 chunks +4 lines, -1 line 0 comments Download
M components/autofill/core/browser/webdata/autofill_wallet_metadata_syncable_service.cc View 1 chunk +4 lines, -1 line 0 comments Download
M components/autofill/core/browser/webdata/autofill_wallet_metadata_syncable_service_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M components/autofill/core/browser/webdata/autofill_wallet_syncable_service.cc View 1 chunk +4 lines, -1 line 0 comments Download
M components/autofill/core/browser/webdata/autofill_webdata_backend.h View 2 chunks +7 lines, -0 lines 0 comments Download
M components/autofill/core/browser/webdata/autofill_webdata_backend_impl.h View 3 chunks +4 lines, -1 line 0 comments Download
M components/autofill/core/browser/webdata/autofill_webdata_backend_impl.cc View 2 chunks +16 lines, -2 lines 0 comments Download
M components/autofill/core/browser/webdata/autofill_webdata_service.h View 2 chunks +3 lines, -0 lines 0 comments Download
M components/autofill/core/browser/webdata/autofill_webdata_service.cc View 2 chunks +22 lines, -10 lines 0 comments Download
M components/autofill/core/browser/webdata/autofill_webdata_service_observer.h View 2 chunks +4 lines, -0 lines 0 comments Download
M components/browser_sync/browser/profile_sync_service_autofill_unittest.cc View 6 chunks +25 lines, -8 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Mathieu
4 years, 5 months ago (2016-07-19 19:58:12 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
23f01b8469b9a91180398faf2ac9feb687b2ef6e.

Powered by Google App Engine
This is Rietveld 408576698