Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2163773002: Mojo C++ bindings: remove use_new_wrapper_types=false from all remaining targets im mojo/ folder. (Closed)

Created:
4 years, 5 months ago by yzshen1
Modified:
4 years, 5 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mojo C++ bindings: remove use_new_wrapper_types=false from all remaining targets im mojo/ folder. BUG=624136 Committed: https://crrev.com/e6fcf92ec826c6b56672eec154e2075b1d01cf60 Cr-Commit-Position: refs/heads/master@{#406382}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -30 lines) Patch
M mojo/common/BUILD.gn View 2 chunks +0 lines, -4 lines 0 comments Download
M mojo/edk/js/tests/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M mojo/edk/js/tests/js_to_cpp_tests.cc View 4 chunks +22 lines, -18 lines 0 comments Download
M mojo/mojo_base.gyp View 2 chunks +0 lines, -2 lines 0 comments Download
M mojo/mojo_edk_tests.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/mojo_public.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/public/interfaces/bindings/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
yzshen1
4 years, 5 months ago (2016-07-19 19:21:54 UTC) #4
yzshen1
On 2016/07/19 19:21:54, yzshen1 wrote: Hi, Ken. Would you please take a look? Thanks!
4 years, 5 months ago (2016-07-19 19:22:12 UTC) #5
Ken Rockot(use gerrit already)
\o/ LGTM
4 years, 5 months ago (2016-07-19 19:31:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2163773002/1
4 years, 5 months ago (2016-07-19 19:33:57 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-19 21:25:16 UTC) #10
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-19 21:25:19 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-07-19 21:27:43 UTC) #13
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/e6fcf92ec826c6b56672eec154e2075b1d01cf60
Cr-Commit-Position: refs/heads/master@{#406382}

Powered by Google App Engine
This is Rietveld 408576698