scripts/slave/recipes/chromium.expected/full_chromium_Win_x64.json - Issue 2163763002: Switch 'Win x64' builder on chromium waterfall to use MB.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipes/chromium.expected/full_chromium_Win_x64.json

Issue 2163763002: Switch 'Win x64' builder on chromium waterfall to use MB. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « scripts/slave/recipe_modules/chromium_tests/chromium.py ('k') | scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_win_x64_archive.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipes/chromium.expected/full_chromium_Win_x64.json

diff --git a/scripts/slave/recipes/chromium.expected/full_chromium_Win_x64.json b/scripts/slave/recipes/chromium.expected/full_chromium_Win_x64.json

index eb5cd5329e4411352caee7e4b3b2874296fd2811..caf51a3bad0ded18c812cb90f002bca3fb7389fc 100644

--- a/scripts/slave/recipes/chromium.expected/full_chromium_Win_x64.json

+++ b/scripts/slave/recipes/chromium.expected/full_chromium_Win_x64.json

@@ -218,6 +218,7 @@

"cwd": "[BUILDER_CACHE]\\Win_x64\\src",

"env": {

"GOMA_SERVICE_ACCOUNT_JSON_FILE": "C:\\creds\\service_accounts\\service-account-goma-client.json",

+ "GYP_CHROMIUM_NO_ACTION": "1",

"GYP_DEFINES": "component=static_library fastbuild=1 gomadir='[CACHE]\\cipd\\goma' linux_dump_symbols=0 target_arch=x64 test_isolation_mode=noop use_goma=1",

"PATH": "%(PATH)s;RECIPE_PACKAGE_REPO[depot_tools]"

@@ -274,6 +275,28 @@

"cmd": [

"python",

"-u",

+ "[BUILDER_CACHE]\\Win_x64\\src\\tools\\mb\\mb.py",

+ "gen",

+ "-m",

+ "chromium",

+ "-b",

+ "Win x64",

+ "--config-file",

+ "[BUILDER_CACHE]\\Win_x64\\src\\tools\\mb\\mb_config.pyl",

+ "--goma-dir",

+ "[CACHE]\\cipd\\goma",

+ "//out/Release_x64"

+ ],

+ "cwd": "[BUILDER_CACHE]\\Win_x64\\src",

+ "env": {

+ "GOMA_SERVICE_ACCOUNT_JSON_FILE": "C:\\creds\\service_accounts\\service-account-goma-client.json"

+ },

+ "name": "generate_build_files"

+ },

+ {

+ "cmd": [

+ "python",

+ "-u",

"RECIPE_PACKAGE_REPO[build]\\scripts\\tools\\runit.py",

"--show-path",

"python",