base/task_scheduler/task_scheduler_impl.h - Issue 2163753004: Rename CancellationFlag to AtomicFlag.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/task_scheduler/task_scheduler_impl.h

Issue 2163753004: Rename CancellationFlag to AtomicFlag. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: self-review (remove unused includes) Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/task_scheduler/task_scheduler_impl.h

diff --git a/base/task_scheduler/task_scheduler_impl.h b/base/task_scheduler/task_scheduler_impl.h

index ac827f7de53b0c1655f76b7944e885947a0ce62c..1722eeee4e9afc93b3467e768b9bae8c3dff7371 100644

--- a/base/task_scheduler/task_scheduler_impl.h

+++ b/base/task_scheduler/task_scheduler_impl.h

@@ -16,7 +16,7 @@

#include "base/logging.h"

#include "base/macros.h"

#include "base/memory/ref_counted.h"

-#include "base/synchronization/waitable_event.h"

+#include "base/synchronization/atomic_flag.h"

#include "base/task_runner.h"

#include "base/task_scheduler/delayed_task_manager.h"

#include "base/task_scheduler/scheduler_worker_pool_impl.h"

@@ -105,8 +105,8 @@ class BASE_EXPORT TaskSchedulerImpl : public TaskScheduler {

std::unique_ptr<SchedulerServiceThread> service_thread_;

#if DCHECK_IS_ON()

- // Signaled once JoinForTesting() has returned.

- WaitableEvent join_for_testing_returned_;

+ // Set once JoinForTesting() has returned.

+ AtomicFlag join_for_testing_returned_;

#endif

DISALLOW_COPY_AND_ASSIGN(TaskSchedulerImpl);