Use shelf handlers in ScheduledServer.

sdk/lib/_internal/pub/test/pub_uploader_test.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library pub_uploader_test;
 
 import 'dart:convert';
 import 'dart:io';
 
 import 'package:scheduled_test/scheduled_process.dart';
 import 'package:scheduled_test/scheduled_server.dart';
 import 'package:scheduled_test/scheduled_test.dart';
+import 'package:shelf/shelf.dart' as shelf;
 
 import '../lib/src/exit_codes.dart' as exit_codes;
 import '../lib/src/io.dart';
 import '../lib/src/utils.dart';
 import 'descriptor.dart' as d;
 import 'test_pub.dart';
 
 final USAGE_STRING = '''
 Manage uploaders for a package on pub.dartlang.org.
 
@@ skipping 31 matching lines @@
           output: USAGE_STRING, exitCode: exit_codes.USAGE);
     });
   });
 
   integration('adds an uploader', () {
     var server = new ScheduledServer();
     d.credentialsFile(server, 'access token').create();
     var pub = startPubUploader(server, ['--package', 'pkg', 'add', 'email']);
 
     server.handle('POST', '/api/packages/pkg/uploaders', (request) {
-      expect(new ByteStream(request).toBytes().then((bodyBytes) {
-        expect(new String.fromCharCodes(bodyBytes), equals('email=email'));
+      return request.readAsString().then((body) {
+        expect(body, equals('email=email'));
 
-        request.response.headers.contentType =
-            new ContentType("application", "json");
-        request.response.write(JSON.encode({
+        return new shelf.Response.ok(JSON.encode({
           'success': {'message': 'Good job!'}
-        }));
-        request.response.close();
-      }), completes);
+        }), headers: {'content-type': 'application/json'});
+      });
     });
 
     pub.stdout.expect('Good job!');
     pub.shouldExit(exit_codes.SUCCESS);
   });
 
   integration('removes an uploader', () {
     var server = new ScheduledServer();
     d.credentialsFile(server, 'access token').create();
     var pub = startPubUploader(server, ['--package', 'pkg', 'remove', 'email']);
 
     server.handle('DELETE', '/api/packages/pkg/uploaders/email', (request) {
-      request.response.headers.contentType =
-          new ContentType("application", "json");
-      request.response.write(JSON.encode({
+      return new shelf.Response.ok(JSON.encode({
         'success': {'message': 'Good job!'}
-      }));
-      request.response.close();
+      }), headers: {'content-type': 'application/json'});
     });
 
     pub.stdout.expect('Good job!');
     pub.shouldExit(exit_codes.SUCCESS);
   });
 
   integration('defaults to the current package', () {
     d.validPackage.create();
 
     var server = new ScheduledServer();
     d.credentialsFile(server, 'access token').create();
     var pub = startPubUploader(server, ['add', 'email']);
 
     server.handle('POST', '/api/packages/test_pkg/uploaders', (request) {
-      request.response.headers.contentType =
-          new ContentType("application", "json");
-      request.response.write(JSON.encode({
+      return new shelf.Response.ok(JSON.encode({
         'success': {'message': 'Good job!'}
-      }));
+      }), headers: {'content-type': 'application/json'});
       request.response.close();
     });
 
     pub.stdout.expect('Good job!');
     pub.shouldExit(exit_codes.SUCCESS);
   });
 
   integration('add provides an error', () {
     var server = new ScheduledServer();
     d.credentialsFile(server, 'access token').create();
     var pub = startPubUploader(server, ['--package', 'pkg', 'add', 'email']);
 
     server.handle('POST', '/api/packages/pkg/uploaders', (request) {
-      request.response.statusCode = 400;
-      request.response.headers.contentType =
-          new ContentType("application", "json");
-      request.response.write(JSON.encode({
-        'error': {'message': 'Bad job!'}
-      }));
-      request.response.close();
+      return new shelf.Response(400,
+          body: JSON.encode({'error': {'message': 'Bad job!'}}),
+          headers: {'content-type': 'application/json'});
     });
 
     pub.stderr.expect('Bad job!');
     pub.shouldExit(1);
   });
 
   integration('remove provides an error', () {
     var server = new ScheduledServer();
     d.credentialsFile(server, 'access token').create();
     var pub = startPubUploader(server,
         ['--package', 'pkg', 'remove', 'e/mail']);
 
     server.handle('DELETE', '/api/packages/pkg/uploaders/e%2Fmail', (request) {
-      request.response.statusCode = 400;
-      request.response.headers.contentType =
-          new ContentType("application", "json");
-      request.response.write(JSON.encode({
-        'error': {'message': 'Bad job!'}
-      }));
-      request.response.close();
+      return new shelf.Response(400,
+          body: JSON.encode({'error': {'message': 'Bad job!'}}),
+          headers: {'content-type': 'application/json'});
     });
 
     pub.stderr.expect('Bad job!');
     pub.shouldExit(1);
   });
 
   integration('add provides invalid JSON', () {
     var server = new ScheduledServer();
     d.credentialsFile(server, 'access token').create();
     var pub = startPubUploader(server, ['--package', 'pkg', 'add', 'email']);
 
-    server.handle('POST', '/api/packages/pkg/uploaders', (request) {
-      request.response.write("{not json");
-      request.response.close();
-    });
+    server.handle('POST', '/api/packages/pkg/uploaders',
+        (request) => new shelf.Response.ok("{not json"));
 
     pub.stderr.expect(emitsLines(
         'Invalid server response:\n'
         '{not json'));
     pub.shouldExit(1);
   });
 
   integration('remove provides invalid JSON', () {
     var server = new ScheduledServer();
     d.credentialsFile(server, 'access token').create();
     var pub = startPubUploader(server, ['--package', 'pkg', 'remove', 'email']);
 
-    server.handle('DELETE', '/api/packages/pkg/uploaders/email', (request) {
-      request.response.write("{not json");
-      request.response.close();
-    });
+    server.handle('DELETE', '/api/packages/pkg/uploaders/email',
+        (request) => new shelf.Response.ok("{not json"));
 
     pub.stderr.expect(emitsLines(
         'Invalid server response:\n'
         '{not json'));
     pub.shouldExit(1);
   });
 }