Ignore mojo connection errors during shutdown in Geolocation.

third_party/WebKit/Source/modules/geolocation/Geolocation.cpp

 /*
  * Copyright (C) 2008, 2009, 2010, 2011 Apple Inc. All Rights Reserved.
  * Copyright (C) 2009 Torch Mobile, Inc.
  * Copyright 2010, The Android Open Source Project
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
@@ skipping 17 matching lines @@
 #include "modules/geolocation/Geolocation.h"
 
 #include "core/dom/Document.h"
 #include "core/frame/Deprecation.h"
 #include "core/frame/HostsUsingFeatures.h"
 #include "core/frame/Settings.h"
 #include "modules/geolocation/Coordinates.h"
 #include "modules/geolocation/GeolocationError.h"
 #include "platform/UserGestureIndicator.h"
 #include "platform/mojo/MojoHelper.h"
+#include "public/platform/Platform.h"
 #include "public/platform/ServiceRegistry.h"
 #include "wtf/Assertions.h"
 #include "wtf/CurrentTime.h"
 
 namespace blink {
 namespace {
 
 static const char permissionDeniedErrorMessage[] = "User denied Geolocation";
 static const char failedToStartServiceErrorMessage[] = "Failed to start Geolocation service";
 static const char framelessDocumentErrorMessage[] = "Geolocation cannot be used in frameless documents";
@@ skipping 471 matching lines @@
         queryNextPosition();
 }
 
 void Geolocation::pageVisibilityChanged()
 {
     updateGeolocationServiceConnection();
 }
 
 void Geolocation::onGeolocationConnectionError()
 {
+    // If a request is outstanding at process shutdown, this error handler will
+    // be called. In that case, |this| is not really in a good state so do
+    // nothing.
+    if (!Platform::current())

[haraken, 2016/07/20 07:15:01]

It looks nasty to have this kind of check in Blink. Would there be any way to
prevent the onerror callbacks from getting called after blink::shutdown is
called?

[Michael van Ouwerkerk, 2016/07/20 09:40:50]

This does seem a little out of place. It seems that either 1) we should put this
type of checks in many more places throughout Blink or 2) a more generic
solution in a single place would be cleaner.

+        return;
+
     PositionError* error = PositionError::create(PositionError::POSITION_UNAVAILABLE, failedToStartServiceErrorMessage);
     error->setIsFatal(true);
     handleError(error);
 }
 
 void Geolocation::onPermissionConnectionError()
 {
+    // If a request is outstanding at process shutdown, this error handler will
+    // be called. In that case, |this| is not really in a good state so do
+    // nothing.
+    if (!Platform::current())
+        return;
+
     onGeolocationPermissionUpdated(mojom::blink::PermissionStatus::DENIED);
 }
 
 } // namespace blink