src/core/SkColorMatrixFilterRowMajor255.cpp - Issue 2163683002: Correct sRGB <-> linear everywhere.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/core/SkColorMatrixFilterRowMajor255.cpp

Issue 2163683002: Correct sRGB <-> linear everywhere. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Fix! Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/core/SkColorMatrixFilterRowMajor255.cpp

diff --git a/src/core/SkColorMatrixFilterRowMajor255.cpp b/src/core/SkColorMatrixFilterRowMajor255.cpp

index cdfd1df49604e26e0c2a6b2998465be06ebf6b8b..29a3f107b8f020d76525f926f72e88b14405f043 100644

--- a/src/core/SkColorMatrixFilterRowMajor255.cpp

+++ b/src/core/SkColorMatrixFilterRowMajor255.cpp

@@ -126,7 +126,7 @@ struct SkPMColorAdaptor {

return round(swizzle_rb_if_bgra(c4));

}

static Sk4f To4f(SkPMColor c) {

- return to_4f(c) * Sk4f(1.0f/255);

+ return Sk4f_fromL32(c);

}

};

void SkColorMatrixFilterRowMajor255::filterSpan(const SkPMColor src[], int count, SkPMColor dst[]) const {