Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Side by Side Diff: src/core/SkColor.cpp

Issue 2163683002: Correct sRGB <-> linear everywhere. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: back to brute Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « bench/SkBlend_optsBench.cpp ('k') | src/core/SkColorMatrixFilterRowMajor255.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2006 The Android Open Source Project 2 * Copyright 2006 The Android Open Source Project
3 * 3 *
4 * Use of this source code is governed by a BSD-style license that can be 4 * Use of this source code is governed by a BSD-style license that can be
5 * found in the LICENSE file. 5 * found in the LICENSE file.
6 */ 6 */
7 7
8 #include "SkColor.h" 8 #include "SkColor.h"
9 #include "SkColorPriv.h" 9 #include "SkColorPriv.h"
10 #include "SkFixed.h" 10 #include "SkFixed.h"
(...skipping 88 matching lines...) Expand 10 before | Expand all | Expand 10 after
99 default: r = v; g = p; b = q; break; 99 default: r = v; g = p; b = q; break;
100 } 100 }
101 return SkColorSetARGB(a, r, g, b); 101 return SkColorSetARGB(a, r, g, b);
102 } 102 }
103 103
104 //////////////////////////////////////////////////////////////////////////////// /////////////////// 104 //////////////////////////////////////////////////////////////////////////////// ///////////////////
105 #include "SkPM4fPriv.h" 105 #include "SkPM4fPriv.h"
106 #include "SkHalf.h" 106 #include "SkHalf.h"
107 107
108 SkPM4f SkPM4f::FromPMColor(SkPMColor c) { 108 SkPM4f SkPM4f::FromPMColor(SkPMColor c) {
109 Sk4f value = to_4f_rgba(c); 109 return From4f(swizzle_rb_if_bgra(Sk4f_fromL32(c)));
110 SkPM4f c4;
111 (value * Sk4f(1.0f / 255)).store(&c4);
112 return c4;
113 } 110 }
114 111
115 SkColor4f SkPM4f::unpremul() const { 112 SkColor4f SkPM4f::unpremul() const {
116 float alpha = fVec[A]; 113 float alpha = fVec[A];
117 if (0 == alpha) { 114 if (0 == alpha) {
118 return { 0, 0, 0, 0 }; 115 return { 0, 0, 0, 0 };
119 } else { 116 } else {
120 float invAlpha = 1 / alpha; 117 float invAlpha = 1 / alpha;
121 return { fVec[R] * invAlpha, fVec[G] * invAlpha, fVec[B] * invAlpha, alp ha }; 118 return { fVec[R] * invAlpha, fVec[G] * invAlpha, fVec[B] * invAlpha, alp ha };
122 } 119 }
(...skipping 22 matching lines...) Expand all
145 142
146 #ifdef SK_DEBUG 143 #ifdef SK_DEBUG
147 void SkPM4f::assertIsUnit() const { 144 void SkPM4f::assertIsUnit() const {
148 auto c4 = Sk4f::Load(fVec); 145 auto c4 = Sk4f::Load(fVec);
149 SkASSERT((c4 >= Sk4f(0)).allTrue() && (c4 <= Sk4f(1)).allTrue()); 146 SkASSERT((c4 >= Sk4f(0)).allTrue() && (c4 <= Sk4f(1)).allTrue());
150 } 147 }
151 #endif 148 #endif
152 149
153 //////////////////////////////////////////////////////////////////////////////// /////////////////// 150 //////////////////////////////////////////////////////////////////////////////// ///////////////////
154 151
155 SkColor4f SkColor4f::FromColor(SkColor c) { 152 SkColor4f SkColor4f::FromColor(SkColor bgra) {
156 Sk4f value = SkNx_shuffle<2,1,0,3>(SkNx_cast<float>(Sk4b::Load(&c))); 153 SkColor4f rgba;
157 SkColor4f c4; 154 swizzle_rb(Sk4f_fromS32(bgra)).store(rgba.vec());
158 (value * Sk4f(1.0f / 255)).store(&c4); 155 return rgba;
159 c4.fR = srgb_to_linear(c4.fR);
160 c4.fG = srgb_to_linear(c4.fG);
161 c4.fB = srgb_to_linear(c4.fB);
162 return c4;
163 } 156 }
164 157
165 SkColor SkColor4f::toSkColor() const { 158 SkColor SkColor4f::toSkColor() const {
166 SkColor result; 159 return Sk4f_toS32(swizzle_rb(Sk4f::Load(this->vec())));
167 Sk4f value = Sk4f(linear_to_srgb(fB), linear_to_srgb(fG), linear_to_srgb(fR) , fA);
168 SkNx_cast<uint8_t>(value * Sk4f(255) + Sk4f(0.5f)).store(&result);
169 return result;
170 } 160 }
171 161
172 SkColor4f SkColor4f::Pin(float r, float g, float b, float a) { 162 SkColor4f SkColor4f::Pin(float r, float g, float b, float a) {
173 SkColor4f c4; 163 SkColor4f c4;
174 Sk4f::Min(Sk4f::Max(Sk4f(r, g, b, a), Sk4f(0)), Sk4f(1)).store(c4.vec()); 164 Sk4f::Min(Sk4f::Max(Sk4f(r, g, b, a), Sk4f(0)), Sk4f(1)).store(c4.vec());
175 return c4; 165 return c4;
176 } 166 }
177 167
178 SkPM4f SkColor4f::premul() const { 168 SkPM4f SkColor4f::premul() const {
179 auto src = Sk4f::Load(this->pin().vec()); 169 auto src = Sk4f::Load(this->pin().vec());
180 float srcAlpha = src[3]; // need the pinned version of our alpha 170 float srcAlpha = src[3]; // need the pinned version of our alpha
181 src = src * Sk4f(srcAlpha, srcAlpha, srcAlpha, 1); 171 src = src * Sk4f(srcAlpha, srcAlpha, srcAlpha, 1);
182 172
183 return SkPM4f::From4f(src); 173 return SkPM4f::From4f(src);
184 } 174 }
OLDNEW
« no previous file with comments | « bench/SkBlend_optsBench.cpp ('k') | src/core/SkColorMatrixFilterRowMajor255.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698