mojo/public/cpp/bindings/lib/interface_endpoint_client.cc - Issue 2163633003: Support early associated interface binding on ChannelMojo

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/cpp/bindings/lib/interface_endpoint_client.cc

Issue 2163633003: Support early associated interface binding on ChannelMojo (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@explicit-channel-ipc-task-runner

Patch Set: . Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: mojo/public/cpp/bindings/lib/interface_endpoint_client.cc

diff --git a/mojo/public/cpp/bindings/lib/interface_endpoint_client.cc b/mojo/public/cpp/bindings/lib/interface_endpoint_client.cc

index e1f388aa21a4dd70d5ce615596261242948e2344..9ececaa79863bd798f634f257437d77a9082539e 100644

--- a/mojo/public/cpp/bindings/lib/interface_endpoint_client.cc

+++ b/mojo/public/cpp/bindings/lib/interface_endpoint_client.cc

@@ -159,7 +159,8 @@ InterfaceEndpointClient::InterfaceEndpointClient(

InterfaceEndpointClient::~InterfaceEndpointClient() {

DCHECK(thread_checker_.CalledOnValidThread());

- handle_.group_controller()->DetachEndpointClient(handle_);

+ if (handle_.is_valid())

+ handle_.group_controller()->DetachEndpointClient(handle_);

}

AssociatedGroup* InterfaceEndpointClient::associated_group() {

« no previous file with comments | « ipc/ipc_mojo_bootstrap_unittest.cc ('k') | no next file » | no next file with comments »