Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Unified Diff: ipc/ipc_channel.h

Issue 2163633003: Support early associated interface binding on ChannelMojo (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@explicit-channel-ipc-task-runner
Patch Set: . Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ipc/ipc.mojom ('k') | ipc/ipc_channel_mojo.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ipc/ipc_channel.h
diff --git a/ipc/ipc_channel.h b/ipc/ipc_channel.h
index 8d886b51f19d3ea410a9eddd655051f395b3caed..a1917d936601803829328b8b0b80d4f8271a0a7b 100644
--- a/ipc/ipc_channel.h
+++ b/ipc/ipc_channel.h
@@ -103,10 +103,11 @@ class IPC_EXPORT Channel : public Endpoint {
virtual ~AssociatedInterfaceSupport() {}
// Accesses the AssociatedGroup used to associate new interface endpoints
- // with this Channel.
+ // with this Channel. Must be safe to call from any thread.
virtual mojo::AssociatedGroup* GetAssociatedGroup() = 0;
- // Adds an interface factory to this channel for interface |name|.
+ // Adds an interface factory to this channel for interface |name|. Must be
+ // safe to call from any thread.
virtual void AddGenericAssociatedInterface(
const std::string& name,
const GenericAssociatedInterfaceFactory& factory) = 0;
@@ -116,11 +117,6 @@ class IPC_EXPORT Channel : public Endpoint {
const std::string& name,
mojo::ScopedInterfaceEndpointHandle handle) = 0;
- // Sets the TaskRunner on which to support proxied dispatch for associated
- // interfaces.
- virtual void SetProxyTaskRunner(
- scoped_refptr<base::SingleThreadTaskRunner> task_runner) = 0;
-
// Template helper to add an interface factory to this channel.
template <typename Interface>
using AssociatedInterfaceFactory =
« no previous file with comments | « ipc/ipc.mojom ('k') | ipc/ipc_channel_mojo.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698