Make SkFont a bit more useable

Make SkFont a bit more useable

Split out of https://codereview.chromium.org/2163483002/ (Use SkFont in GrStencilAndCoverTextContext)

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2163633002

Committed: https://skia.googlesource.com/skia/+/e34f17d23699abfc672289f51319b37294b3c257

[robertphillips, 2016-07-19 12:42:50]

Description was changed from

==========
Make SkFont a bit more useable
==========

to

==========
Make SkFont a bit more useable
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2163633002
==========

[robertphillips, 2016-07-19 12:44:13]

Description was changed from

==========
Make SkFont a bit more useable
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2163633002
==========

to

==========
Make SkFont a bit more useable

Split out of https://codereview.chromium.org/2163483002/ (Use SkFont in
GrStencilAndCoverTextContext)

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2163633002
==========

[robertphillips, 2016-07-19 12:44:13]

robertphillips@google.com changed reviewers:
+ fmalita@chromium.org, reed@google.com

[robertphillips, 2016-07-19 12:46:32]

The CQ bit was checked by robertphillips@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-19 12:46:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-19 12:48:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-19 12:48:53]

Dry run: Try jobs failed on following builders:
  Build-Ubuntu-GCC-x86_64-Release-Trybot on master.client.skia.compile
(JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-x86...)

[robertphillips, 2016-07-19 12:52:22]

The CQ bit was checked by robertphillips@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-19 12:52:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-19 13:07:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-19 13:07:09]

Dry run: This issue passed the CQ dry run.

[f(malita), 2016-07-19 14:20:55]

LGTM.

The GetGlyphCacheProc change seems tangential, but probably makes sense in the
context of the bigger CL.

[robertphillips, 2016-07-19 14:44:23]

Wrt GetGlyphCacheProc, it needs to take parameters, rather than relying on
SkPaint's member variables, so that an object that only has an SkFont can also
call it.

[reed1, 2016-07-19 14:56:32]

lgtm

[robertphillips, 2016-07-19 14:58:19]

The CQ bit was checked by robertphillips@google.com

[commit-bot: I haz the power, 2016-07-19 14:58:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-19 14:59:24]

Description was changed from

==========
Make SkFont a bit more useable

Split out of https://codereview.chromium.org/2163483002/ (Use SkFont in
GrStencilAndCoverTextContext)

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2163633002
==========

to

==========
Make SkFont a bit more useable

Split out of https://codereview.chromium.org/2163483002/ (Use SkFont in
GrStencilAndCoverTextContext)

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2163633002

Committed:
https://skia.googlesource.com/skia/+/e34f17d23699abfc672289f51319b37294b3c257
==========

[commit-bot: I haz the power, 2016-07-19 14:59:25]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/e34f17d23699abfc672289f51319b37294b3c257