DescriptionRevert of Enforce singleton not allowed behavior for CONTINUE_ON_SHUTDOWN tasks (patchset #5 id:120001 of https://codereview.chromium.org/1904273002/ )
Reason for revert:
Reverting due to Android failures (https://crbug.com/607317). I hope the logs prove useful (here's one: https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/35333/steps/unit_tests/logs/stdio). Looks like the stacks aren't symbolized, so you may have to go the manual route to track this down.
Original issue's description:
> Enforce singleton not allowed behavior for CONTINUE_ON_SHUTDOWN tasks
>
> CONTINUE_ON_SHUTDOWN means the thread running the task will not be
> joined on shutdown and may not have a valid singleton/lazy_instance
> at that moment.
>
> Also made DhcpcsvcInitSingleton explicitly leaky to avoid
> the AssertSingletonAllowed() dcheck.
>
> BUG=478209
>
> Committed: https://crrev.com/de7e9038663d69356e558764d5a7b215e8b49b5b
> Committed: https://crrev.com/68e03e7337bc3252f874bcf9e50a5830a54eecb0
> Cr-Original-Commit-Position: refs/heads/master@{#390125}
> Cr-Commit-Position: refs/heads/master@{#406053}
TBR=mef@chromium.org,danakj@chromium.org,gab@chromium.org,robliao@chromium.org,manzagop@chromium.org,rsleevi@chromium.org,pmonette@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=478209
Committed: https://crrev.com/d0be3b9013f92de2df440e4e7e99d0286fab2df2
Cr-Commit-Position: refs/heads/master@{#406231}
Patch Set 1 #
Messages
Total messages: 6 (2 generated)
|