Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(597)

Issue 2163603003: Revert of [builtins] Introduce a builtin for Abort(). (Closed)

Created:
4 years, 5 months ago by Michael Hablich
Modified:
4 years, 5 months ago
Reviewers:
Michael Starzinger, v8-mips-ports, ahaas, Benedikt Meurer, v8-arm-ports, titzer, akos.palfi.imgtec
CC:
Hannes Payer (out of office), ulan, v8-mips-ports_googlegroups.com, v8-ppc-ports_googlegroups.com, v8-reviews_googlegroups.com, v8-x87-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [builtins] Introduce a builtin for Abort(). (patchset #5 id:80001 of https://codereview.chromium.org/2156923002/ ) Reason for revert: Blocks roll: https://build.chromium.org/p/client.v8.ports/builders/V8%20Linux%20-%20arm64%20-%20sim%20-%20debug/builds/1622 Original issue's description: > [builtins] Introduce a builtin for Abort(). > > Calling Runtime::kAbort through a builtin instead of the c-entry stub > will allow to generate the call in a background thread, because a > builtin provides its own handle, whereas a code stub does not. > > @v8-mips-ports: Could you take a special look at the padding that is > done in MacroAssembler::Abort()? > > R=bmeurer@chromium.org, titzer@chromium.org, mstarzinger@chromium.org, v8-mips-ports@googlegroups.com, v8-arm-ports@googlegroups.com > > Committed: https://crrev.com/9be015a254cfff871c56cd129523a729637e9158 > Cr-Commit-Position: refs/heads/master@{#37854} TBR=bmeurer@chromium.org,mstarzinger@chromium.org,titzer@chromium.org,v8-arm-ports@googlegroups.com,v8-mips-ports@googlegroups.com,akos.palfi@imgtec.com,ahaas@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/3e8f49ab59206b587c6c44a58eda954a76355409 Cr-Commit-Position: refs/heads/master@{#37883}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -117 lines) Patch
M src/arm/macro-assembler-arm.cc View 1 chunk +4 lines, -6 lines 0 comments Download
M src/arm64/macro-assembler-arm64.cc View 1 chunk +4 lines, -6 lines 0 comments Download
M src/builtins/arm/builtins-arm.cc View 1 chunk +0 lines, -11 lines 0 comments Download
M src/builtins/arm64/builtins-arm64.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M src/builtins/builtins.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/builtins/ia32/builtins-ia32.cc View 1 chunk +0 lines, -13 lines 0 comments Download
M src/builtins/mips/builtins-mips.cc View 1 chunk +0 lines, -11 lines 0 comments Download
M src/builtins/mips64/builtins-mips64.cc View 1 chunk +0 lines, -11 lines 0 comments Download
M src/builtins/x64/builtins-x64.cc View 1 chunk +0 lines, -13 lines 0 comments Download
M src/heap/heap.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 1 chunk +3 lines, -7 lines 0 comments Download
M src/isolate.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M src/mips/macro-assembler-mips.cc View 1 chunk +5 lines, -8 lines 0 comments Download
M src/mips64/macro-assembler-mips64.cc View 1 chunk +5 lines, -8 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 1 chunk +6 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Michael Hablich
Created Revert of [builtins] Introduce a builtin for Abort().
4 years, 5 months ago (2016-07-20 07:21:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2163603003/1
4 years, 5 months ago (2016-07-20 07:22:07 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-20 07:22:24 UTC) #4
commit-bot: I haz the power
4 years, 5 months ago (2016-07-20 07:25:24 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3e8f49ab59206b587c6c44a58eda954a76355409
Cr-Commit-Position: refs/heads/master@{#37883}

Powered by Google App Engine
This is Rietveld 408576698