Fix hyphenation for lang="de" and other fallback on Android

Fix hyphenation for lang="de" and other fallback on Android

This patch fixes 3 issues for hyphenation to work on Android for
lang="de" and some other languages.

1. Android requires additional fallback mapping for "de" and some other
   languages.
2. ASCII digits must be a valid locale.
3. When fallback occurs from platformGetHyphenation(), HashMap fails
   to store the loaded dictionary when it calls get() recursively.

Also fallback list was changed to be lower case to avoid run-time
conversions.

BUG=605840
Committed: https://crrev.com/60ffd3221a5bbfa8f78c36a1957a7af84e16a0e7
Cr-Commit-Position: refs/heads/master@{#406384}

[kojii, 2016-07-19 07:55:14]

The CQ bit was checked by kojii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-19 07:55:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kojii, 2016-07-19 08:12:01]

Description was changed from

==========
hyph

BUG=
==========

to

==========
Fix hyphenation for lang="de" on Android

This patch fixes 3 issues for hyphenation to work on Android for
lang="de".

1. Android requires additional fallback mapping for "de".
2. ASCII digits must be a valid locale.
3. When fallback occurs within platformGetHyphenation(), HashMap fails
   to store the loaded dictionary because fallback calls get()
   recursively.

BUG=605840
==========

[kojii, 2016-07-19 08:23:27]

The CQ bit was checked by kojii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-19 08:23:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-19 11:37:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-19 11:37:56]

Dry run: This issue passed the CQ dry run.

[kojii, 2016-07-19 12:10:38]

Description was changed from

==========
Fix hyphenation for lang="de" on Android

This patch fixes 3 issues for hyphenation to work on Android for
lang="de".

1. Android requires additional fallback mapping for "de".
2. ASCII digits must be a valid locale.
3. When fallback occurs within platformGetHyphenation(), HashMap fails
   to store the loaded dictionary because fallback calls get()
   recursively.

BUG=605840
==========

to

==========
Fix hyphenation for lang="de" and other fallback on Android

This patch fixes 3 issues for hyphenation to work on Android for
lang="de".

1. Android requires additional fallback mapping for "de" and some other
   languages.
2. ASCII digits must be a valid locale.
3. When fallback occurs within platformGetHyphenation(), HashMap fails
   to store the loaded dictionary because fallback calls get()
   recursively.

BUG=605840
==========

[kojii, 2016-07-19 12:12:19]

Description was changed from

==========
Fix hyphenation for lang="de" and other fallback on Android

This patch fixes 3 issues for hyphenation to work on Android for
lang="de".

1. Android requires additional fallback mapping for "de" and some other
   languages.
2. ASCII digits must be a valid locale.
3. When fallback occurs within platformGetHyphenation(), HashMap fails
   to store the loaded dictionary because fallback calls get()
   recursively.

BUG=605840
==========

to

==========
Fix hyphenation for lang="de" and other fallback on Android

This patch fixes 3 issues for hyphenation to work on Android for
lang="de".

1. Android requires additional fallback mapping for "de" and some other
   languages.
2. ASCII digits must be a valid locale.
3. When fallback occurs from platformGetHyphenation(), HashMap fails
   to store the loaded dictionary when it calls get() recursively.

BUG=605840
==========

[kojii, 2016-07-19 13:22:31]

The CQ bit was checked by kojii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-19 13:22:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kojii, 2016-07-19 13:27:28]

Description was changed from

==========
Fix hyphenation for lang="de" and other fallback on Android

This patch fixes 3 issues for hyphenation to work on Android for
lang="de".

1. Android requires additional fallback mapping for "de" and some other
   languages.
2. ASCII digits must be a valid locale.
3. When fallback occurs from platformGetHyphenation(), HashMap fails
   to store the loaded dictionary when it calls get() recursively.

BUG=605840
==========

to

==========
Fix hyphenation for lang="de" and other fallback on Android

This patch fixes 3 issues for hyphenation to work on Android for
lang="de".

1. Android requires additional fallback mapping for "de" and some other
   languages.
2. ASCII digits must be a valid locale.
3. When fallback occurs from platformGetHyphenation(), HashMap fails
   to store the loaded dictionary when it calls get() recursively.

Also fallback list was changed to be lower case to avoid run-time
conversions.

BUG=605840
==========

[kojii, 2016-07-19 14:08:50]

Description was changed from

==========
Fix hyphenation for lang="de" and other fallback on Android

This patch fixes 3 issues for hyphenation to work on Android for
lang="de".

1. Android requires additional fallback mapping for "de" and some other
   languages.
2. ASCII digits must be a valid locale.
3. When fallback occurs from platformGetHyphenation(), HashMap fails
   to store the loaded dictionary when it calls get() recursively.

Also fallback list was changed to be lower case to avoid run-time
conversions.

BUG=605840
==========

to

==========
Fix hyphenation for lang="de" and other fallback on Android

This patch fixes 3 issues for hyphenation to work on Android for
lang="de" and some other languages.

1. Android requires additional fallback mapping for "de" and some other
   languages.
2. ASCII digits must be a valid locale.
3. When fallback occurs from platformGetHyphenation(), HashMap fails
   to store the loaded dictionary when it calls get() recursively.

Also fallback list was changed to be lower case to avoid run-time
conversions.

BUG=605840
==========

[commit-bot: I haz the power, 2016-07-19 14:36:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-19 14:36:30]

Dry run: This issue passed the CQ dry run.

[kojii, 2016-07-19 14:40:43]

kojii@chromium.org changed reviewers:
+ eae@chromium.org

[kojii, 2016-07-19 14:40:44]

PTAL. The last patch didn't work for "de" :-( The "de" dictionary is available
only since N preview, so manual test was needed.

[eae, 2016-07-19 15:13:53]

LGTM w/nit

https://codereview.chromium.org/2163603002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/text/hyphenation/HyphenationMinikin.cpp
(right):

https://codereview.chromium.org/2163603002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/text/hyphenation/HyphenationMinikin.cpp:145:
{ "en", "en-gb" },
Could you add descriptions to three new lines too please?

[kojii, 2016-07-19 15:24:03]

done,  thank you for the prompt review, as always!

[kojii, 2016-07-19 15:24:07]

The CQ bit was checked by kojii@chromium.org

[kojii, 2016-07-19 15:24:07]

The patchset sent to the CQ was uploaded after l-g-t-m from eae@chromium.org
Link to the patchset: https://codereview.chromium.org/2163603002/#ps60001
(title: "eae review")

[commit-bot: I haz the power, 2016-07-19 15:24:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-19 17:52:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-19 17:52:31]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[kojii, 2016-07-19 18:31:31]

The CQ bit was checked by kojii@chromium.org

[commit-bot: I haz the power, 2016-07-19 18:32:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-19 21:29:43]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-07-19 21:33:15]

Description was changed from

==========
Fix hyphenation for lang="de" and other fallback on Android

This patch fixes 3 issues for hyphenation to work on Android for
lang="de" and some other languages.

1. Android requires additional fallback mapping for "de" and some other
   languages.
2. ASCII digits must be a valid locale.
3. When fallback occurs from platformGetHyphenation(), HashMap fails
   to store the loaded dictionary when it calls get() recursively.

Also fallback list was changed to be lower case to avoid run-time
conversions.

BUG=605840
==========

to

==========
Fix hyphenation for lang="de" and other fallback on Android

This patch fixes 3 issues for hyphenation to work on Android for
lang="de" and some other languages.

1. Android requires additional fallback mapping for "de" and some other
   languages.
2. ASCII digits must be a valid locale.
3. When fallback occurs from platformGetHyphenation(), HashMap fails
   to store the loaded dictionary when it calls get() recursively.

Also fallback list was changed to be lower case to avoid run-time
conversions.

BUG=605840

Committed: https://crrev.com/60ffd3221a5bbfa8f78c36a1957a7af84e16a0e7
Cr-Commit-Position: refs/heads/master@{#406384}
==========

[commit-bot: I haz the power, 2016-07-19 21:33:16]

Patchset 4 (id:??) landed as
https://crrev.com/60ffd3221a5bbfa8f78c36a1957a7af84e16a0e7
Cr-Commit-Position: refs/heads/master@{#406384}