Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(935)

Issue 2163573002: Roll gtest. (Closed)

Created:
4 years, 5 months ago by Anand Mistry (off Chromium)
Modified:
4 years, 5 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll gtest. The change in directory structure requires the checkout to be moved to a different directory, and some dummy header files that re-direct to the new location. TBR=juliatuttle@chromium.org Committed: https://crrev.com/4266a7d49d60d3af744bfb513cbdeb716b0b6782 Cr-Commit-Position: refs/heads/master@{#406741}

Patch Set 1 #

Patch Set 2 : gyp build #

Patch Set 3 : gyp #

Patch Set 4 : fix stuff #

Patch Set 5 : Remove template file. #

Patch Set 6 : fix license check #

Patch Set 7 : Add checklicenses excaption. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -320 lines) Patch
M .gitignore View 1 chunk +1 line, -1 line 0 comments Download
M DEPS View 1 chunk +2 lines, -2 lines 0 comments Download
D build/secondary/testing/gtest/BUILD.gn View 1 chunk +0 lines, -160 lines 0 comments Download
M net/socket/sequenced_socket_data_unittest.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M testing/gtest.gyp View 1 4 chunks +5 lines, -4 lines 0 comments Download
M testing/gtest.gypi View 1 2 3 1 chunk +28 lines, -8 lines 0 comments Download
A + testing/gtest/BUILD.gn View 1 2 3 4 chunks +31 lines, -26 lines 0 comments Download
A + testing/gtest/include/gtest/gtest.h View 1 chunk +1 line, -1 line 0 comments Download
A + testing/gtest/include/gtest/gtest-death-test.h View 1 2 3 1 chunk +1 line, -6 lines 0 comments Download
A + testing/gtest/include/gtest/gtest-message.h View 1 chunk +1 line, -6 lines 0 comments Download
A + testing/gtest/include/gtest/gtest-param-test.h View 1 chunk +1 line, -6 lines 0 comments Download
A + testing/gtest/include/gtest/gtest-printers.h View 1 2 3 1 chunk +1 line, -6 lines 0 comments Download
A + testing/gtest/include/gtest/gtest-spi.h View 1 chunk +1 line, -6 lines 0 comments Download
A + testing/gtest/include/gtest/gtest-test-part.h View 1 2 3 1 chunk +1 line, -6 lines 0 comments Download
A + testing/gtest/include/gtest/gtest-typed-test.h View 1 2 3 1 chunk +1 line, -6 lines 0 comments Download
A + testing/gtest/include/gtest/gtest_pred_impl.h View 1 2 3 1 chunk +1 line, -6 lines 0 comments Download
A + testing/gtest/include/gtest/gtest_prod.h View 1 chunk +1 line, -6 lines 0 comments Download
A + testing/gtest/include/gtest/internal/gtest-death-test-internal.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + testing/gtest/include/gtest/internal/gtest-filepath.h View 1 2 3 1 chunk +1 line, -6 lines 0 comments Download
A + testing/gtest/include/gtest/internal/gtest-internal.h View 1 2 3 1 chunk +1 line, -6 lines 0 comments Download
A + testing/gtest/include/gtest/internal/gtest-linked_ptr.h View 1 2 3 1 chunk +1 line, -6 lines 0 comments Download
A + testing/gtest/include/gtest/internal/gtest-param-util.h View 1 2 3 1 chunk +1 line, -6 lines 0 comments Download
A + testing/gtest/include/gtest/internal/gtest-param-util-generated.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + testing/gtest/include/gtest/internal/gtest-port.h View 1 2 3 1 chunk +1 line, -6 lines 0 comments Download
A + testing/gtest/include/gtest/internal/gtest-port-arch.h View 1 2 3 1 chunk +1 line, -6 lines 0 comments Download
A + testing/gtest/include/gtest/internal/gtest-string.h View 1 2 3 1 chunk +1 line, -6 lines 0 comments Download
A + testing/gtest/include/gtest/internal/gtest-tuple.h View 1 2 3 1 chunk +1 line, -6 lines 0 comments Download
A + testing/gtest/include/gtest/internal/gtest-type-util.h View 1 2 3 1 chunk +1 line, -6 lines 0 comments Download
M testing/gtest_nacl.gyp View 1 2 3 chunks +4 lines, -4 lines 0 comments Download
M tools/checklicenses/checklicenses.py View 1 2 3 4 5 6 1 chunk +4 lines, -0 lines 0 comments Download
M tools/licenses.py View 1 2 3 4 5 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 37 (26 generated)
Anand Mistry (off Chromium)
Proudly presenting today's episode of "CLs that probably won't get committed".
4 years, 5 months ago (2016-07-20 01:46:52 UTC) #16
Paweł Hajdan Jr.
LGTM
4 years, 5 months ago (2016-07-20 15:17:10 UTC) #17
Anand Mistry (off Chromium)
agrieve@chromium.org: build file move juliatuttle@chromium.org: for trivial //net change
4 years, 5 months ago (2016-07-20 23:34:03 UTC) #22
agrieve
On 2016/07/20 23:34:03, Anand Mistry wrote: > mailto:agrieve@chromium.org: build file move > > mailto:juliatuttle@chromium.org: for ...
4 years, 5 months ago (2016-07-21 01:55:50 UTC) #25
Anand Mistry (off Chromium)
net_unittest change is trivial, so TBRing it.
4 years, 5 months ago (2016-07-21 02:01:09 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2163573002/120001
4 years, 5 months ago (2016-07-21 02:02:06 UTC) #30
commit-bot: I haz the power
Committed patchset #7 (id:120001)
4 years, 5 months ago (2016-07-21 02:08:16 UTC) #32
commit-bot: I haz the power
Patchset 7 (id:??) landed as https://crrev.com/4266a7d49d60d3af744bfb513cbdeb716b0b6782 Cr-Commit-Position: refs/heads/master@{#406741}
4 years, 5 months ago (2016-07-21 02:09:42 UTC) #34
piman
A revert of this CL (patchset #7 id:120001) has been created in https://codereview.chromium.org/2171663002/ by piman@chromium.org. ...
4 years, 5 months ago (2016-07-21 03:01:55 UTC) #35
Anand Mistry (off Chromium)
On 2016/07/21 03:01:55, piman wrote: > A revert of this CL (patchset #7 id:120001) has ...
4 years, 5 months ago (2016-07-21 06:57:47 UTC) #36
tzik
4 years, 5 months ago (2016-07-21 20:45:50 UTC) #37
Message was sent while issue was closed.
On 2016/07/21 06:57:47, Anand Mistry wrote:
> On 2016/07/21 03:01:55, piman wrote:
> > A revert of this CL (patchset #7 id:120001) has been created in
> > https://codereview.chromium.org/2171663002/ by mailto:piman@chromium.org.
> > 
> > The reason for reverting is: Looks like this broke gyp:
> >
>
https://build.chromium.org/p/chromium.win/builders/Win8%20GYP%20%28dbg%29/bui...
> >
>
https://build.chromium.org/p/chromium.mac/builders/Mac%20GYP%20%28dbg%29/buil...
> > 
> > The issue seems non-trivial to fix (may need an angle roll), so reverting..
> 
> Sigh! Single line fix in angle:
https://chromium-review.googlesource.com/362093

JFYI: after another change I'm submitting, angle change will no longer needed.
https://codereview.chromium.org/2168983002/

Powered by Google App Engine
This is Rietveld 408576698