Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(510)

Issue 2163543005: Check duplicates when scanning selected files for cloud import. (Closed)

Created:
4 years, 5 months ago by yamaguchi
Modified:
4 years, 5 months ago
Reviewers:
fukino
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Check duplicates when scanning selected files for cloud import. BUG=628583 TEST=manual UI test and unit test Committed: https://crrev.com/49b1b36c7a38bf0b88f53da54e447b6f4a1eb126 Cr-Commit-Position: refs/heads/master@{#406518}

Patch Set 1 #

Patch Set 2 : sync to head #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -1 line) Patch
M ui/file_manager/file_manager/background/js/media_scanner.js View 1 chunk +1 line, -1 line 0 comments Download
M ui/file_manager/file_manager/background/js/media_scanner_unittest.js View 1 chunk +42 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
yamaguchi
PTAL
4 years, 5 months ago (2016-07-20 06:57:05 UTC) #2
fukino
lgtm. Thank you!
4 years, 5 months ago (2016-07-20 08:01:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2163543005/20001
4 years, 5 months ago (2016-07-20 08:06:16 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-20 08:42:51 UTC) #6
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-20 08:42:56 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-07-20 08:44:22 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/49b1b36c7a38bf0b88f53da54e447b6f4a1eb126
Cr-Commit-Position: refs/heads/master@{#406518}

Powered by Google App Engine
This is Rietveld 408576698