Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 2163543003: Hook up new V8 use counters (Closed)

Created:
4 years, 5 months ago by jochen (gone - plz use gerrit)
Modified:
4 years, 5 months ago
Reviewers:
Ilya Sherman, Mike West
CC:
asvitkine+watch_chromium.org, blink-reviews, blink-reviews-bindings_chromium.org, chromium-reviews, Dan Ehrenberg, bakkot
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Hook up new V8 use counters R=mkwst@chromium.org TBR=isherman@chromium.org BUG= Committed: https://crrev.com/6b18bef3019bba9bef74483d8a02be78a756c7f0 Cr-Commit-Position: refs/heads/master@{#406266}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.cpp View 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 chunk +2 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
jochen (gone - plz use gerrit)
4 years, 5 months ago (2016-07-19 12:41:51 UTC) #1
Mike West
LGTM.
4 years, 5 months ago (2016-07-19 12:43:05 UTC) #4
jochen (gone - plz use gerrit)
TBR'ing isherman@ for script-generated change to histograms.xml
4 years, 5 months ago (2016-07-19 12:46:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2163543003/1
4 years, 5 months ago (2016-07-19 12:46:32 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-19 13:56:37 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/6b18bef3019bba9bef74483d8a02be78a756c7f0 Cr-Commit-Position: refs/heads/master@{#406266}
4 years, 5 months ago (2016-07-19 13:58:01 UTC) #11
Ilya Sherman
4 years, 5 months ago (2016-07-20 01:45:25 UTC) #12
Message was sent while issue was closed.
histograms.xml lgtm

Powered by Google App Engine
This is Rietveld 408576698