Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 216353003: Allow #pixelsX = #pixelsY +-1 to fix WebRtcGetUserMediaBrowserTest.TestGetUserMediaAspectX (Closed)

Created:
6 years, 9 months ago by perkj_chrome
Modified:
6 years, 9 months ago
Reviewers:
mcasas
CC:
chromium-reviews, feature-media-reviews_chromium.org, jam, darin-cc_chromium.org
Visibility:
Public.

Description

Allow #pixelsX = #pixelsY +-1 to fix WebRtcGetUserMediaBrowserTest.TestGetUserMediaAspectX These tests draw a light green circle on a background. The test expect a certain background color, but what color the edge of the circle has is undefined. BUG=357279 R=mcasas@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260090

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M content/test/data/media/getusermedia.html View 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
perkj_chrome
Please take a look.
6 years, 9 months ago (2014-03-28 07:02:55 UTC) #1
mcasas
lgtm
6 years, 9 months ago (2014-03-28 07:48:24 UTC) #2
perkj_chrome
6 years, 9 months ago (2014-03-28 08:07:32 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r260090 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698