Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Issue 2163513002: Add FramesSentAsOverlay UMA metric to AVDA. (Closed)

Created:
4 years, 5 months ago by liberato (no reviews please)
Modified:
4 years, 5 months ago
Reviewers:
watk, Ilya Sherman
CC:
chromium-reviews, posciak+watch_chromium.org, piman+watch_chromium.org, asvitkine+watch_chromium.org, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add FramesSentAsOverlay UMA metric to AVDA. This metric records frames sent by AVDA, bucketed by whether they are or are not overlays. The goal is to provide an approximate count of how often SurfaceView is used versus SurfaceTexture. BUG=629313 Committed: https://crrev.com/ba0333059d47c4a9baa604d0def3ce2b3f6afee3 Cr-Commit-Position: refs/heads/master@{#406712}

Patch Set 1 #

Total comments: 1

Patch Set 2 : fixed boolean description #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
M media/gpu/android_video_decode_accelerator.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 chunks +14 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
liberato (no reviews please)
4 years, 5 months ago (2016-07-18 23:43:06 UTC) #3
watk
lgtm
4 years, 5 months ago (2016-07-19 19:51:54 UTC) #4
liberato (no reviews please)
isherman: PTAL @ histograms.xml watk: thanks thanks -fl
4 years, 5 months ago (2016-07-19 20:52:05 UTC) #6
Ilya Sherman
LGTM % a comment: https://codereview.chromium.org/2163513002/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/2163513002/diff/1/tools/metrics/histograms/histograms.xml#newcode67490 tools/metrics/histograms/histograms.xml:67490: + <int value="1" label="Frame was ...
4 years, 5 months ago (2016-07-20 02:17:04 UTC) #7
liberato (no reviews please)
indeed, you're right. thanks! -fl
4 years, 5 months ago (2016-07-20 22:01:50 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2163513002/20001
4 years, 5 months ago (2016-07-20 22:03:19 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-20 23:38:02 UTC) #13
commit-bot: I haz the power
4 years, 5 months ago (2016-07-20 23:40:59 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ba0333059d47c4a9baa604d0def3ce2b3f6afee3
Cr-Commit-Position: refs/heads/master@{#406712}

Powered by Google App Engine
This is Rietveld 408576698