Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Unified Diff: gpu/GLES2/extensions/CHROMIUM/CHROMIUM_schedule_ca_layer.txt

Issue 2163493002: Break glScheduleCALayerCHROMIUM into smaller functions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@temp37_cleanup_calayeroverlay
Patch Set: Rebase. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/output/gl_renderer.cc ('k') | gpu/GLES2/gl2chromium_autogen.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gpu/GLES2/extensions/CHROMIUM/CHROMIUM_schedule_ca_layer.txt
diff --git a/gpu/GLES2/extensions/CHROMIUM/CHROMIUM_schedule_ca_layer.txt b/gpu/GLES2/extensions/CHROMIUM/CHROMIUM_schedule_ca_layer.txt
index 29606b230b07ff4cdcfd64cdd0824e274cf95ce0..d7a07ccfa171656af2daf8f952cdd13c7ed105b9 100644
--- a/gpu/GLES2/extensions/CHROMIUM/CHROMIUM_schedule_ca_layer.txt
+++ b/gpu/GLES2/extensions/CHROMIUM/CHROMIUM_schedule_ca_layer.txt
@@ -39,37 +39,56 @@ New Procedures and Functions
The command
+ glScheduleCALayerSharedStateCHROMIUM(GLfloat opacity,
+ GLboolean is_clipped,
+ const GLfloat* clip_rect,
+ GLint sorting_context_id,
+ const GLfloat* transform);
+
+ sets state that will be shared by each subsequent call to
+ glScheduleCALayerCHROMIUM. A subsequent call to
+ glScheduleCALayerSharedStateCHROMIUM overrides the previous shared state
+ values.
+ <opacity> specifies the opacity of the CALayer.
+ <is_clipped> indicates if the layer should be clipped.
+ <clip_rect> contains four values indicating the x, y, width, and height of
+ the rectangle to clip the layer to, if it is to be clipped.
+ <sorting_context_id> Layers in a non-zero sorting context exist in the same
+ 3D space and should intersect.
+ <transform> contains sixteen values indicating the row major order 4x4
+ transformation matrix to apply to the CALayer.
+
+ The command
+
ccameron 2016/07/19 20:29:51 Let's just have SwapBuffers automatically clear th
erikchen 2016/07/19 20:42:26 Done.
+ glUnscheduleCALayerSharedStateCHROMIUM();
+
+ unsets the state set by glScheduleCALayerSharedStateCHROMIUM. This command
+ is used to prevent shared state from leaking into inappropriate frames.
+
+ The command
+
glScheduleCALayerCHROMIUM(GLuint contents_texture_id,
const GLfloat* contents_rect,
- GLfloat opacity,
GLuint background_color,
GLuint edge_aa_mask,
const GLfloat* bounds_rect,
- GLboolean is_clipped,
- const GLfloat* clip_rect,
- const GLfloat* transform,
GLuint filter);
- Set the CALayer parameters to be presented at the time of the next call to
- swap buffers. The order of the calls schedule CALayers determines their
- back-to-front presentation order.
+ requires that shared state has been previously set by
+ glScheduleCALayerSharedStateCHROMIUM. It sets the CALayer parameters to be
+ presented at the time of the next call to swap buffers. The order of the
+ calls schedule CALayers determines their back-to-front presentation order.
<contents_texture_id> is the texture to be presented. If zero, then the
CALayer will be a solid color.
<contents_rect> contains four values indicating the x, y, width, and height
of the sub-rectangle to display from the texture specified in
<contents_texture_id>, in normalized coordinates.
- <opacity> specifies the opacity of the CALayer.
<background_color> specifies the background color of the CALayer, as a
32-bit ARGB value.
<edge_aa_mask> is a bitfield specifying which of the edges of the layer are
to have anti-aliasing.
<bounds_rect> contains four values indicating the x, y, width, and height of
the layer in pixels.
- <is_clipped> indicates if the layer should be clipped.
- <clip_rect> contains four values indicating the x, y, width, and height of
- the rectangle to clip the layer to, if it is to be clipped.
- <transform> contains sixteen values indicating the row major order 4x4
- transformation matrix to apply to the CALayer.
<filter> will be used for both minification and magnification filtering. The
only valid values are GL_LINEAR and GL_NEAREST.
« no previous file with comments | « cc/output/gl_renderer.cc ('k') | gpu/GLES2/gl2chromium_autogen.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698