Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issue 2163463002: Delete SkXMLPullParser (Closed)

Created:
4 years, 5 months ago by f(malita)
Modified:
4 years, 5 months ago
Reviewers:
robertphillips, reed1
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -210 lines) Patch
M gyp/xml.gyp View 1 chunk +0 lines, -5 lines 0 comments Download
M include/xml/SkXMLParser.h View 1 chunk +0 lines, -68 lines 0 comments Download
D src/xml/SkXMLPullParser.cpp View 1 chunk +0 lines, -137 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
f(malita)
4 years, 5 months ago (2016-07-18 21:27:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2163463002/1
4 years, 5 months ago (2016-07-18 21:27:38 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: skia_presubmit-Trybot on master.client.skia.fyi (JOB_FAILED, http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/builds/11382)
4 years, 5 months ago (2016-07-18 21:29:08 UTC) #6
robertphillips
lgtm
4 years, 5 months ago (2016-07-18 21:55:40 UTC) #7
reed1
lgtm
4 years, 5 months ago (2016-07-19 10:28:33 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2163463002/1
4 years, 5 months ago (2016-07-19 12:13:46 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-19 12:14:44 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/fd75dd4086971783053facde4ec6abee55afb780

Powered by Google App Engine
This is Rietveld 408576698