Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Side by Side Diff: ash/shelf/shelf_tooltip_manager.cc

Issue 2163453002: mus: Change PointerWatcher to watch for all events. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add back location Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ash/shelf/shelf_tooltip_manager.h" 5 #include "ash/shelf/shelf_tooltip_manager.h"
6 6
7 #include "ash/common/shell_window_ids.h" 7 #include "ash/common/shell_window_ids.h"
8 #include "ash/shelf/shelf.h" 8 #include "ash/shelf/shelf.h"
9 #include "ash/shelf/shelf_layout_manager.h" 9 #include "ash/shelf/shelf_layout_manager.h"
10 #include "ash/shelf/shelf_view.h" 10 #include "ash/shelf/shelf_view.h"
(...skipping 155 matching lines...) Expand 10 before | Expand all | Expand 10 after
166 } 166 }
167 167
168 void ShelfTooltipManager::ShowTooltipWithDelay(views::View* view) { 168 void ShelfTooltipManager::ShowTooltipWithDelay(views::View* view) {
169 if (ShouldShowTooltipForView(view)) { 169 if (ShouldShowTooltipForView(view)) {
170 timer_.Start(FROM_HERE, base::TimeDelta::FromMilliseconds(timer_delay_), 170 timer_.Start(FROM_HERE, base::TimeDelta::FromMilliseconds(timer_delay_),
171 base::Bind(&ShelfTooltipManager::ShowTooltip, 171 base::Bind(&ShelfTooltipManager::ShowTooltip,
172 weak_factory_.GetWeakPtr(), view)); 172 weak_factory_.GetWeakPtr(), view));
173 } 173 }
174 } 174 }
175 175
176 void ShelfTooltipManager::OnMousePressed(const ui::MouseEvent& event, 176 void ShelfTooltipManager::OnPointerEventObserved(
177 const gfx::Point& location_in_screen, 177 const ui::LocatedEvent& event,
178 views::Widget* target) { 178 const gfx::Point& location_in_screen,
179 // Close on any mouse press events inside or outside the tooltip. 179 views::Widget* target) {
180 // Close on any press events inside or outside the tooltip.
180 Close(); 181 Close();
181 } 182 }
182 183
183 void ShelfTooltipManager::OnTouchPressed(const ui::TouchEvent& event,
184 const gfx::Point& location_in_screen,
185 views::Widget* target) {
186 // Close on any touch press events inside or outside the tooltip.
187 Close();
188 }
189
190 void ShelfTooltipManager::OnEvent(ui::Event* event) { 184 void ShelfTooltipManager::OnEvent(ui::Event* event) {
191 // Mouse and touch press events are handled via views::PointerWatcher. 185 // Mouse and touch press events are handled via views::PointerWatcher.
192 if (event->type() == ui::ET_MOUSE_PRESSED || 186 if (event->type() == ui::ET_MOUSE_PRESSED ||
193 event->type() == ui::ET_TOUCH_PRESSED) { 187 event->type() == ui::ET_TOUCH_PRESSED) {
194 return; 188 return;
195 } 189 }
196 190
197 if (event->type() == ui::ET_MOUSE_EXITED || !event->IsMouseEvent() || 191 if (event->type() == ui::ET_MOUSE_EXITED || !event->IsMouseEvent() ||
198 event->target() != shelf_view_->GetWidget()->GetNativeWindow()) { 192 event->target() != shelf_view_->GetWidget()->GetNativeWindow()) {
199 if (!event->IsKeyEvent()) 193 if (!event->IsKeyEvent())
(...skipping 50 matching lines...) Expand 10 before | Expand all | Expand 10 after
250 base::Bind(&ShelfTooltipManager::Close, weak_factory_.GetWeakPtr())); 244 base::Bind(&ShelfTooltipManager::Close, weak_factory_.GetWeakPtr()));
251 } 245 }
252 } 246 }
253 247
254 bool ShelfTooltipManager::ShouldShowTooltipForView(views::View* view) { 248 bool ShelfTooltipManager::ShouldShowTooltipForView(views::View* view) {
255 return shelf_view_ && shelf_view_->ShouldShowTooltipForView(view) && 249 return shelf_view_ && shelf_view_->ShouldShowTooltipForView(view) &&
256 shelf_layout_manager_ && shelf_layout_manager_->IsVisible(); 250 shelf_layout_manager_ && shelf_layout_manager_->IsVisible();
257 } 251 }
258 252
259 } // namespace ash 253 } // namespace ash
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698