ash: CloseWindowedAppsFromRemovedExtension skips empty browser

ash: CloseWindowedAppsFromRemovedExtension skips empty browser

Fix the crash on attempting to close an empty browser that is caused
by a racing when the test extension closes its window and
uninstalls itself at the same time.

BUG=628871
TEST=meacer_extension_apis passes.

Committed: https://crrev.com/b71bcd50ab29a5aaab734e151740845f8ef3753b
Cr-Commit-Position: refs/heads/master@{#406157}

[xiyuan, 2016-07-18 22:08:25]

xiyuan@chromium.org changed reviewers:
+ stevenjb@chromium.org

[xiyuan, 2016-07-18 22:08:44]

The CQ bit was checked by xiyuan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-18 22:09:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[stevenjb, 2016-07-18 22:14:09]

https://codereview.chromium.org/2163443003/diff/1/chrome/browser/ui/ash/launc...
File chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.cc (right):

https://codereview.chromium.org/2163443003/diff/1/chrome/browser/ui/ash/launc...
chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.cc:1501: profile
== browser->profile() && !browser->tab_strip_model()->empty()) {
Even though it is functionally equivalent and slightly more work, I think this
test would be more intuitive before line 1507, what do you think?

[xiyuan, 2016-07-18 22:28:53]

https://codereview.chromium.org/2163443003/diff/1/chrome/browser/ui/ash/launc...
File chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.cc (right):

https://codereview.chromium.org/2163443003/diff/1/chrome/browser/ui/ash/launc...
chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.cc:1501: profile
== browser->profile() && !browser->tab_strip_model()->empty()) {
On 2016/07/18 22:14:09, stevenjb wrote:
> Even though it is functionally equivalent and slightly more work, I think this
> test would be more intuitive before line 1507, what do you think?

sgtm. moved.

[stevenjb, 2016-07-18 22:36:53]

lgtm

[stevenjb, 2016-07-18 22:37:03]

On 2016/07/18 22:36:53, stevenjb wrote:
> lgtm

and thanks!

[xiyuan, 2016-07-18 22:42:07]

The CQ bit was checked by xiyuan@chromium.org

[commit-bot: I haz the power, 2016-07-18 22:42:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-19 00:00:38]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-19 00:00:41]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-19 00:02:06]

Description was changed from

==========
ash: CloseWindowedAppsFromRemovedExtension skips empty browser

Fix the crash on attempting to close an empty browser that is caused
by a racing when the test extension closes its window and
uninstalls itself at the same time.

BUG=628871
TEST=meacer_extension_apis passes.
==========

to

==========
ash: CloseWindowedAppsFromRemovedExtension skips empty browser

Fix the crash on attempting to close an empty browser that is caused
by a racing when the test extension closes its window and
uninstalls itself at the same time.

BUG=628871
TEST=meacer_extension_apis passes.

Committed: https://crrev.com/b71bcd50ab29a5aaab734e151740845f8ef3753b
Cr-Commit-Position: refs/heads/master@{#406157}
==========

[commit-bot: I haz the power, 2016-07-19 00:02:07]

Patchset 2 (id:??) landed as
https://crrev.com/b71bcd50ab29a5aaab734e151740845f8ef3753b
Cr-Commit-Position: refs/heads/master@{#406157}