Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Unified Diff: LayoutTests/fast/dom/Window/resources/window-property-collector.js

Issue 216343002: Add a test that confirms there's no crash on accessing properties of AccesibilityObject at the init… (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: dmazzoni's review Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/fast/dom/Window/resources/window-property-collector.js
diff --git a/LayoutTests/fast/dom/Window/resources/window-property-collector.js b/LayoutTests/fast/dom/Window/resources/window-property-collector.js
index 0578c8d46adccf4811b7105a05e527df2932789e..c40bfa32e7a66eb582608f90631ead2bc1cd58fa 100644
--- a/LayoutTests/fast/dom/Window/resources/window-property-collector.js
+++ b/LayoutTests/fast/dom/Window/resources/window-property-collector.js
@@ -20,10 +20,15 @@ function emitExpectedResult(path, expected)
if (path[0] == 'internals'
|| path[0] == 'propertiesToVerify' // Skip the list we're building...
|| path[0] == 'clientInformation' // Just an alias for navigator.
- // Skip testRunner since they are only for testing.
- || path[0] == 'testRunner'
- || path[0] == 'eventSender' // Skip eventSender since they are only for testing.
- || path[0] == 'layoutTestController') { // Just an alias for testRunner.
+ || path[0] == 'testRunner' // Skip testRunner since they are only for testing.
+ || path[0] == 'layoutTestController' // Just an alias for testRunner.
+ || path[0] == 'eventSender') { // Skip eventSender since they are only for testing.
+ return;
+ }
+
+ // Skip the properties which are hard to expect a stable result.
+ if (path[0] == 'accessibilityController' // we can hardly estimate the states of the cached WebAXObjects.
+ || path[0] == 'localStorage') { // local storage is not reliably cleared between tests.
return;
}
@@ -75,16 +80,6 @@ function collectPropertiesHelper(object, path)
throw 'Error: probably looping';
for (var property in object) {
- // Skip the properties which are hard to expect a stable result.
- // As for 'accessibilityController', we can hardly estimate the states
- // of the cached WebAXObjects.
- // FIXME: We can't access accessibilityController's properties here
- // because some property accesses might crash (crbug/351195).
- if (property == 'accessibilityController')
- continue;
- // As for 'localStorage', local storage is not reliably cleared between tests.
- if (property == 'localStorage')
- continue;
path.push(property);
var type = typeof(object[property]);
if (type == "object") {

Powered by Google App Engine
This is Rietveld 408576698